Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Comment not found #1406

Closed
1 task done
frank-connolly opened this issue Sep 6, 2024 · 2 comments
Closed
1 task done

🐛 BUG: Comment not found #1406

frank-connolly opened this issue Sep 6, 2024 · 2 comments

Comments

@frank-connolly
Copy link

frank-connolly commented Sep 6, 2024

What went wrong? 🤔

image
Despite the notification above I do not see the comment on this post. I believe this is happening with all similar notifications for the Welcome post in this squad. Clicking the notification simply brings me to the post, scrolling down to load comments does not reveal it. This is on desktop.

Expected Behavior

  • The comment on the post should be visible
  • Clicking the notification should take me to the comment.

Steps to Reproduce Issue

1. Go to (Just Java squad welcome post)[https://app.daily.dev/posts/4lkF85AjX]
2. Search for the comment as described in the notification screenshot in 'What went wrong?' section
3. Unable to locate comment.

Solution Proposed

This used to work. I suspect (if no recent changes in related code) the large number of comments for that post is causing some logic to not function as intended. Perhaps the design never factored in this number of comments.

Screenshots

![DESCRIPTION](LINK.png)

Environment

Ubuntu

Browsers

Chrome

OS

Linux

Version of daily.dev

No response

Additional Context

No response

Code of Conduct

  • I follow the conditions of this project.
@frank-connolly frank-connolly changed the title 🐛 BUG: 🐛 BUG: Comment not found Sep 6, 2024
@idoshamun
Copy link
Member

Hi @frank-connolly,

I think we have an issue with very long discussions. We'll have to think how to address that.
Thanks for reporting

@rebelchris
Copy link
Contributor

We recently bumped the comment list to load more, which should solve this issue.
We are internally looking at re-doing the comment section so will close this as resolved for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants