Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X1->Y0 fall-through intended? #5

Open
kajott opened this issue Jul 5, 2023 · 2 comments
Open

X1->Y0 fall-through intended? #5

kajott opened this issue Jul 5, 2023 · 2 comments

Comments

@kajott
Copy link

kajott commented Jul 5, 2023

I have no clue at all about quantum computing, but looking at the code, the fall-through from line 428 (X1 gate) to 440 (Y0 gate) seems odd. Is that intended, or is it a bug?

@ergo70
Copy link

ergo70 commented Aug 31, 2023

I assume that the fallthrough is unintentional since no other gate does it?

@ergo70
Copy link

ergo70 commented Aug 31, 2023

I'm pretty sure now, this is not correct.
This is a two QBit only system, so all gates working on a single QBit are duplicated and suffixed 0 or 1. Gates that do work on both QBits, like CNOT (CX) have no suffix, because it's obvious that they affect 0 and 1. I further assume that X is the Pauli-X and Y is the Pauli-Y gate (https://en.wikipedia.org/wiki/Quantum_logic_gate). Both work on a single QBit. So, X1 is Pauli-X on QBit 1, and Y0 is Pauli-Y on QBit 0. It makes no sense that X1 also triggers Y0. Different single QBit-Gate operations on different QBits must not directly affect each other, especially since there is no equivalent fallthrough for X0 and Y1. I have corrected this in my FORTRAN port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants