Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git formatted output with quotes #33

Open
sickOscar opened this issue Jan 13, 2017 · 4 comments
Open

git formatted output with quotes #33

sickOscar opened this issue Jan 13, 2017 · 4 comments

Comments

@sickOscar
Copy link

First of all, thank you for your work.

The output of all the commands with --format option (lastCommitTime, lastCommitMessage, lastCommitAuthor) is surrounded with double quotes.
Is there any specific reason? I mean, the format option in git doesn't need double quotes, and it is giving me some troubles using it with preprocess/usemin while putting in an html attribute.

If I can suggest a change, it would simply be to remove double quotes from the option

'local.branch.current.lastCommitTime' : ['log', '--format=%ai', '-n1', 'HEAD'], 'local.branch.current.lastCommitMessage' : ['log', '--format=%B', '-n1', 'HEAD'], 'local.branch.current.lastCommitAuthor' : ['log', '--format=%aN', '-n1', 'HEAD'],

If you agree I can submit a PR.

Cheers

@drasive
Copy link
Contributor

drasive commented Jan 13, 2017

I'm having the same problem.
I had opened PR #21 which got closed as cannot reproduce after 1.5 years (it was not a good solution, though).

@sickOscar
Copy link
Author

Good to know. @drasive do you agree with my solution?
I'm using the npm published version of this package for building in a production env now. If @damkraw can't reproduce this issue, I will definitely fork and use my version. It would be unfortunate though.

@drasive
Copy link
Contributor

drasive commented Jan 15, 2017

Yes I absolutely agree with your solution.
@damkraw said he only tried to reproduce it on Mac OS and Linux, maybe it only affects Windows?
I would be unfortunate but I would use your fork, as it is a requirement for me.

@greenc
Copy link

greenc commented Feb 20, 2017

This issue also occurs for me on macOS, at least for local.branch.current.lastCommitTime (have not tested the other properties).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants