Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing message about copying of files #219

Closed
znichollscr opened this issue Sep 11, 2024 · 4 comments
Closed

Confusing message about copying of files #219

znichollscr opened this issue Sep 11, 2024 · 4 comments

Comments

@znichollscr
Copy link

The on_post_page method looks like the below. prints a message about copying files. However, as far as I can tell, this method will copy the file without actually checking if the file is a notebook file or not. Hence, you get messages about files being copied, even though they're not actually notebook files. For example, you get messages like "Copied jupyter file: .../docs/changelog.md to .../site/changelog/changelog.md". As far as I can tell, these are misleading. The file being copied isn't a jupyter file, it's just a file. I'm not sure if the behaviour is correct either, should mkdocs-jupyter be doing this copying or is that really the responsibility of mkdocs, and mkdocs-jupyter should only be copying files that are actually related to notebooks?

@davidknight-seequent
Copy link

I've been wondering the same thing! Seems like a bug to me.

@danielfrg
Copy link
Owner

I think this is fixed by #222

@znichollscr
Copy link
Author

Super, thank you!

@danielfrg
Copy link
Owner

closing for now but reopen if this is still an issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants