[Bug]: to_pdf Plugin: Cross-Device File Move Fails with os.Rename

[wmahfoudh]

What happened?

I run to_pdf sample.tex and had this error Error moving output file: rename /tmp/latex_1847002621/input.pdf sample.pdf: invalid cross-device link

The to_pdf plugin fails when attempting to move a generated PDF file across different filesystems using the os.Rename function.

Found out that this issue is triggered because my /tmp folder and the current working directory are mounted on separate filesystems.

Output of the df showing different file systems (using btrfs here):

df /tmp . 
Filesystem      Size  Used Avail Use% Mounted on
tmpfs           7.5G  996K  7.5G   1% /tmp
/dev/nvme0n1p3  1.8T  653G  1.2T  37% /home

Version check

• Yes I was.

Relevant log output

Environment Details:

    Operating System: Arch Linux
    Plugin Version: to_pdf (latest)
    
FileSystem:

    df /tmp .
    Filesystem      Size  Used Avail Use% Mounted on
    tmpfs           7.5G  996K  7.5G   1% /tmp
    /dev/nvme0n1p3  1.8T  653G  1.2T  37% /home

Relevant screenshots (optional)

No response

[wmahfoudh]

Replacing os.Rename with a combination of io.Copy and os.Remove solves the issue. I will raise a pull request.

// Modified Code
err = copyFile(pdfPath, outputFile)
if err != nil {
    fmt.Fprintf(os.Stderr, "Error moving output file: %v\\n", err)
    os.Exit(1)
}

// Function to copy files
func copyFile(src, dst string) error {
    sourceFile, err := os.Open(src)
    if err != nil {
        return err
    }
    defer sourceFile.Close()

    destFile, err := os.Create(dst)
    if err != nil {
        return err
    }
    defer destFile.Close()

    _, err = io.Copy(destFile, sourceFile)
    if err != nil {
        return err
    }

    return destFile.Sync()
}