Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pouch Collection removeChild removes first in collection when no index found #6

Open
daveyjclark opened this issue May 29, 2015 · 0 comments

Comments

@daveyjclark
Copy link

When you have a collection with deleted items the removeChild function looks up the index but can return 'undefined'. In this case the call to collection.splice will remove the first item in the list which is not the desired behaviour.

I fixed it for me by checking on index before removing.

// Remove the item from the collection
if (index) {
collection.splice(index, 1);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant