From b8aa604cd7168e0c03ebb707d57e41e38270810c Mon Sep 17 00:00:00 2001 From: Daniel Tang Date: Wed, 4 Oct 2023 22:44:49 -0400 Subject: [PATCH] Fix respecting serverapp.terminals_enabled Fixes #85 --- jupyter_server_terminals/app.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/jupyter_server_terminals/app.py b/jupyter_server_terminals/app.py index 6e4fd8d..0bdc14d 100644 --- a/jupyter_server_terminals/app.py +++ b/jupyter_server_terminals/app.py @@ -36,6 +36,8 @@ class TerminalsExtensionApp(ExtensionApp): def initialize_settings(self) -> None: """Initialize settings.""" + if not self.serverapp.terminals_enabled: + return self.initialize_configurables() self.settings.update( {"terminals_available": True, "terminal_manager": self.terminal_manager} @@ -70,6 +72,9 @@ def initialize_configurables(self) -> None: def initialize_handlers(self) -> None: """Initialize handlers.""" + if not self.serverapp.terminals_enabled: + # Checking self.terminals_available instead breaks enabling terminals + return self.handlers.append( ( r"/terminals/websocket/(\w+)",