Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: a11y: side panel buttons still reachable with a screenreader when sidebar is collapsed #5118

Closed
1 task done
fcnjd opened this issue Dec 28, 2024 · 2 comments · Fixed by #5123
Closed
1 task done
Labels
a11y Accessibility bug Something isn't working

Comments

@fcnjd
Copy link
Contributor

fcnjd commented Dec 28, 2024

What happened?

I'm blind and use a screenreader. Since the last update, the button to expand and collapse the side panel is well-labeled and as the correct attributes that inform the screenreader about the current state. When it is expanded, all controls are labelled as well. However, when it's collapsed, the corresponding buttons are still present on the interface, but not with their labels. but e.g. com_sidepanel_conversation_tags. I'd expect the bar to be closed, so the buttons shouldn't stay in the interface.

Steps to Reproduce

  1. Open Librechat
  2. Collapse the side bar
  3. Use the tab key which still focuses the buttons
  4. If you need, turn on a screenreader to confirm that they're read out

What browsers are you seeing the problem on?

Firefox, Chrome

Relevant log output

No response

Screenshots

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fcnjd fcnjd added the bug Something isn't working label Dec 28, 2024
@danny-avila
Copy link
Owner

Thanks for your feedback and glad you can use LibreChat. When the side panel is collapsed, the buttons should still be present with their collapsed versions.

There are 3 states for the side panel:

  1. Expanded, controls have full view
  2. Collapsed, control buttons are still present and when pressed, switches the panel to expanded state to bring selected control to full view
  3. Hidden, side panel is completely hidden, this is triggered by selecting "Hide Panel" button within the side panel.

Using NVDA, I see they are not properly labeled in their collapsed versions as you said, so I will close this issue when that is resolved.

@danny-avila danny-avila added the a11y Accessibility label Dec 28, 2024
@danny-avila danny-avila linked a pull request Dec 28, 2024 that will close this issue
9 tasks
@fcnjd
Copy link
Contributor Author

fcnjd commented Dec 28, 2024

Thank you for clarifying this, I didn't know about those three states. I can definitely use LibreChat with NVDA and am now a happy user for almost a year. Thank you for all your work in this, and I'm glad to see you already addressed those accessibility issues, it's very cool you're so much into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants