Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's impossible to select points on a touch device #400

Open
danvk opened this issue Oct 20, 2014 · 4 comments
Open

It's impossible to select points on a touch device #400

danvk opened this issue Oct 20, 2014 · 4 comments

Comments

@danvk
Copy link
Owner

danvk commented Oct 20, 2014

From danvdk on May 01, 2013 14:32:57

Visit dygraphs.com/tests/demo.html on an iPad and tap the chart. Nothing happens.

There's a pull request which addresses this: #244 Calling "g.mouseMove_(event)" in touchstart also fixes the issue but has the downside of generating select events even when the chart is being panned.

The ideal solution would check if the touch ever moved in touchend and do the selection there if it didn't. This would be analogous to the way we distinguish click/drag and click.

Original issue: http://code.google.com/p/dygraphs/issues/detail?id=469

@kbaggott
Copy link
Collaborator

kbaggott commented Feb 1, 2016

I have created a pull request in regards to this #723, please take a look when you get a chance.
Thanks

@masonlouchart
Copy link

masonlouchart commented Apr 26, 2016

Maybe this issue could be on the milestone 2.0.0 ?

@kwokkie
Copy link

kwokkie commented May 10, 2016

calling g.mouseMove_(event) in touchstart doesn't seem fix the issue on Android mobile phones (mine is Motorola Moto G, Android 5.1.1).

@numerized
Copy link

Hello here
Any news on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants