Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails with solc 0.5.8 #4

Open
elenadimitrova opened this issue May 17, 2019 · 1 comment
Open

Compilation fails with solc 0.5.8 #4

elenadimitrova opened this issue May 17, 2019 · 1 comment

Comments

@elenadimitrova
Copy link

Error:

/lib/dappsys/stop.sol:33:34: TypeError: This modifier uses "msg.value" or "callvalue()" and thus the function has to be payable or internal.
    function start() public auth note {
                                 ^--^
/lib/dappsys/note.sol:36:20: "msg.value" or "callvalue()" appear here inside the modifier.
            wad := callvalue
                   ^-------^
@gbalabasquer
Copy link
Contributor

Yes it is a known issue with compilers > 0.5.6.
We are probably removing the callvalue soon.

elenadimitrova added a commit to JoinColony/colonyNetwork that referenced this issue May 17, 2019
as these have an issue with the latest solc 0.5.8
Logged dapphub/ds-note#4
elenadimitrova added a commit to JoinColony/colonyNetwork that referenced this issue May 19, 2019
as these have an issue with the latest solc 0.5.8
Logged dapphub/ds-note#4
elenadimitrova added a commit to JoinColony/colonyNetwork that referenced this issue May 19, 2019
elenadimitrova added a commit to JoinColony/colonyNetwork that referenced this issue May 19, 2019
elenadimitrova added a commit to JoinColony/colonyNetwork that referenced this issue May 19, 2019
elenadimitrova added a commit to JoinColony/colonyNetwork that referenced this issue May 20, 2019
as these have an issue with the latest solc 0.5.8
Logged dapphub/ds-note#4
elenadimitrova added a commit to JoinColony/colonyNetwork that referenced this issue May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants