Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement submit for changing BLS to execution #212

Open
pablomendezroyo opened this issue Mar 30, 2023 · 3 comments
Open

Implement submit for changing BLS to execution #212

pablomendezroyo opened this issue Mar 30, 2023 · 3 comments
Labels
P1 Medium priority

Comments

@pablomendezroyo
Copy link
Contributor

Tools like Wagyu allow you to create a JSON file to be submitted to the beacon to implement the BLS to execution. Implement a "submit" to import this generated JSON file to the beacon in the Bran UI

@pablomendezroyo pablomendezroyo added the P1 Medium priority label Mar 30, 2023
@Pol-Lanski
Copy link
Member

Pol-Lanski commented Mar 30, 2023

This is how I see the flow happening in dappnode:

Option 1: Submission happens in Dappnode

Screenshot 2023-03-30 at 11 55 43
Screenshot 2023-03-30 at 11 56 06
Screenshot 2023-03-30 at 11 56 19

@Pol-Lanski
Copy link
Member

Pol-Lanski commented Mar 30, 2023

Option 2: Don't create a submission tool and reuse beaconcha.in's tool:

option 2-1

In "Step 1" The button says "Instructions" 😅

Beaconcha.in submission page: https://beaconcha.in/tools/broadcast

@Pol-Lanski
Copy link
Member

Option 1

Pros:

  • User has full control, submits to their own beacon node

Cons:

  • More development, potentially duplicating work

Option 2

Pros:

  • Less work, less duplication, faster GTM

Cons:

  • Dependant of an external service.

Since we don't want people to create the message in Dappnode because it's an online machine, this means that they will have to go out to use an external service for the message creation anyway (Wagyu FTW). Hence it seems reasonable that we also link them to the beaconcha.in service for submitting the message.

On our side, we cover them by warning them that their withdrawal address is NOT 0x01 automatically and immediately offering a resolution path. For me that's the important part and it doesn't matter so much whether they submit to their beacon node or they submit in Beaconcha.in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants