Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEV smoothing pool - add to import view #253

Open
pablomendezroyo opened this issue Jul 26, 2023 · 2 comments
Open

MEV smoothing pool - add to import view #253

pablomendezroyo opened this issue Jul 26, 2023 · 2 comments
Assignees

Comments

@pablomendezroyo
Copy link
Contributor

pablomendezroyo commented Jul 26, 2023

Add MEV smoothing pool fee recipient to the import view. There should be a toggle:

  • It should be toggled by default
  • If toggled, then put the mev smoothing pool fee recipient and do not allow to edit it.
  • Only show the toggle if tag is "solo" staker
  • Add a copy explaining the smoothing pool and redirecting to an external link
@pablomendezroyo pablomendezroyo changed the title Add mev smoothing pool fee recipient to import view MEV smoothing pool - add to import view Nov 9, 2023
@dappnodedev
Copy link
Contributor

dappnodedev commented Dec 1, 2023

I would add 2 points here:

  1. Setting the Smooth fee recipient to the validators will cause those validators to be automatically subscribed to Smooth. Therefore, if they change it to another address and they propose a block they will be banned from Smooth. We must:

    1.1. Show an alert when the Smooth FR is checked in the import view that warns the users about this. Something like: "You will be automatically subscribed to Smooth once you propose a block. If you want to change the fee recipient, remember to unsubscribe here (link) before, in order to prevent this validator to be banned from Smooth"
    1.2. Make sure the "Edit Fee Recipient" feature also warns the user about this when they try to change from the Smooth fee recipient to another one

  2. We might not want it to be selected by default, because if this risk-of-ban situation

@Marketen
Copy link
Contributor

Marketen commented Dec 1, 2023

I agree with @dappnodedev here, we should not make this default, at least for now. If selecting Smooth as fee recipient, we have to inform the user about the consequences of doing so (link to docs, autosubscribe, etc).

User shouldnt be able to edit fee recipient if toggle is active, like @pablomendezroyo said. We could add a "I have unsubscribed from smooth" button to enable editing fee recipient of that validator again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants