Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement initial chocolatey packaging workflow #1400

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Apr 11, 2024

Description

This implements an initial packaging workflow for pushing to the Chocolatey community repo when a release is tagged.

The CHOCOLATEY_TOKEN is required to be set prior to merging - available in the 1Password vault.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #172

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mikeee mikeee requested review from a team as code owners April 11, 2024 17:18
@mikeee mikeee force-pushed the chocolatey-package-management branch from df9034e to 752f850 Compare April 11, 2024 17:25
@mikeee mikeee marked this pull request as draft April 11, 2024 20:24
@mikeee mikeee force-pushed the chocolatey-package-management branch from 752f850 to 549f6fb Compare April 11, 2024 20:46
@mikeee mikeee marked this pull request as ready for review April 11, 2024 20:46
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label May 12, 2024
@mikeee
Copy link
Member Author

mikeee commented May 12, 2024

@dapr/maintainers-cli @dapr/approvers-cli please could you offer some thoughts on this.

@dapr-bot dapr-bot removed the stale label May 12, 2024
Copy link
Member

@shubham1172 shubham1172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a high-level and a cursory reading of the docs. Some comments.

<authors>The Dapr Authors</authors>
<projectUrl>https://dapr.io/</projectUrl>
<iconUrl>https://cdn.jsdelivr.net/gh/dapr/website/static/images/dapr.svg</iconUrl>
<copyright>Copyright 2021 The Dapr Authors</copyright>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<copyright>Copyright 2021 The Dapr Authors</copyright>
<copyright>Copyright 2024 The Dapr Authors</copyright>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also provide scripts to uninstall and upgrade? (I understand this is a first implementation, shooting my ideas).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chocolatey includes an autoinstaller - I've validated this works with the msi installer/uninstaller

# Update script url
- name: Update install script url
shell: pwsh
run: Get-Content tools/chocolateyInstall.ps1 | foreach{$_.replace("dapr_cli_url", "https://github.com/dapr/cli/releases/download/v$env:DAPR_CLI_VERSION/dapr.msi")} | Set-Content -Path tools/chocolateyInstall.ps1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the tools directory to .github/choco/tools? This will be consistent with winget.

@mikeee mikeee requested a review from shubham1172 June 18, 2024 15:20
@dapr-bot
Copy link
Collaborator

dapr-bot commented Aug 8, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added stale and removed stale labels Aug 8, 2024
@dapr-bot
Copy link
Collaborator

dapr-bot commented Sep 7, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Sep 7, 2024
@dapr-bot
Copy link
Collaborator

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Sep 14, 2024
@mikeee mikeee reopened this Sep 14, 2024
@dapr-bot dapr-bot removed the stale label Sep 14, 2024
@mikeee
Copy link
Member Author

mikeee commented Oct 29, 2024

@dapr/maintainers-cli ping

@yaron2
Copy link
Member

yaron2 commented Oct 29, 2024

I'm in favor of this, let's try to get it merged this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chocolatey package for cli install on Windows.
5 participants