Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Zeebe version + Camunda renamed their repository for the GO client #3425

Open
akkie opened this issue May 24, 2024 · 5 comments
Labels
help wanted Extra attention is needed kind/enhancement New feature or request

Comments

@akkie
Copy link
Contributor

akkie commented May 24, 2024

Background

Camunda yesterday renamed the https://camunda/zeebe repository to https://camunda/camunda. This repo contains also the GO client.

I already tried to update to the latest version which should reference the new repository. But it seems that there is an issue with the latest version which points to the old lib.

camunda/camunda#18795

Release Note

RELEASE NOTE: UPDATE Zeebe lib to 8.5.1.

@akkie akkie added the kind/bug Something isn't working label May 24, 2024
@akkie
Copy link
Contributor Author

akkie commented May 24, 2024

@vimateck, @fabistb FYI

@berndverst berndverst added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Jun 3, 2024
@berndverst
Copy link
Member

Can you please provide some details as to the need to update the library? Every library update introduces risks for the project and components after all, so there needs to be a specific reason for modifying dependency versions.

The name change is not a problem.

Ideally you could make the PR and I can review it.

@berndverst berndverst added the help wanted Extra attention is needed label Jun 3, 2024
@akkie
Copy link
Contributor Author

akkie commented Jun 6, 2024

Camunda itself releases a new client version for each new version of the Camunda platform. The subset of functionality we use in the binding is usually backward compatible. But from time to time it makes sense to update the versions as well, because there might be bug fixes for features we use in the binding.

The current version of the Camunda platform is 8.5.1. In the binding we use 8.2.12, which is a bit old. Camunda releases a new minor version every 6 months.

As the Camunda developers mentioned in the linked issue, the next version should have the new naming. So I would wait for that release and then create a PR that bumps to the current version.

FYI: Camunda will release a new API with version 8.6.0 in October which is REST based and will deprecate the current GO client which is gRPC based. The gRPC API will be removed completely with version 8.8.0. They will also provide a GO client for the new API. The idea then was to create a new binding version once the new REST based client was available.

@elena-kolevska
Copy link
Contributor

I did a quick walk through the versions, and these seem to be the changes. I don't know the library, nor zeebe, but at a first glance, the only ones that might be useful in dapr are the first three. @akkie do you have more insight?

  • go-client: Job worker polling backoff mechanism (#6150)
  • Job worker should apply backoff on job polling in case of service unavailable (#4443)
  • Support UpdateJobTimeout RPC in Go Client (#15366)
  • zbctl 8.4.0 can't send requests with authorization information (#16015)
  • Go client commands allow specifying a tenantId / tenantIds property (#15153)
  • Add multi-tenancy support in the Zeebe Go client (#14477)
  • Zbctl (latest) is not working with SaaS (#15524)
  • fix: go client omit optional scope param if not set (#18154)

@akkie
Copy link
Contributor Author

akkie commented Sep 19, 2024

@elena-kolevska You asked because of my PR to update to the latest version?

All the go client related bug fixes are relevant for the Dapr binding. The current #3540 PR is only a maintenance PR. I think it's also the last update for this client, because Camunda will deprecate the gRPC API and the GO client in October. What happens next is written in the stars. Please see camunda/issues#835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants