Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript quickstarts need npm audit fixes #1063

Closed
joebowbeer opened this issue Jul 24, 2024 · 4 comments · Fixed by #1081
Closed

javascript quickstarts need npm audit fixes #1063

joebowbeer opened this issue Jul 24, 2024 · 4 comments · Fixed by #1081
Assignees
Labels
language/javascript Pull requests that update Javascript code P1
Milestone

Comments

@joebowbeer
Copy link
Contributor

In almost every javascript quickstart (and probably tutorial) the npm i installation in each package folder reports audit findings.

Most are fixed by npm audit fix

In some cases an upgrade to axios v1 is needed, which requires a npm audit fix --force

Dependabot should be able to generate PRs for these.

This is a sequel to #1054 (which reported pub_sub audit findings)

Expected Behavior

Running npm i in a javascript folder with package*.json does not report npm audit findings.

Actual Behavior

A handful of audit findings reported in each folder.

Steps to Reproduce the Problem

  1. cd to source folder, e.g., configuration/javascript/sdk/order-processor
  2. npm i
@joebowbeer
Copy link
Contributor Author

/assign joebowbeer

I will create a PR for this

@paulyuk paulyuk added the language/javascript Pull requests that update Javascript code label Jul 29, 2024
@paulyuk paulyuk added this to the 1.14 milestone Jul 29, 2024
@paulyuk
Copy link
Contributor

paulyuk commented Jul 29, 2024

If we can rebase and sync your PR @joebowbeer I'd love to take it for 1.14 release. Please track in that issue

@paulyuk paulyuk added the P1 label Jul 29, 2024
@joebowbeer
Copy link
Contributor Author

Thanks. I finished rebasing my branch on 1.14

@paulyuk
Copy link
Contributor

paulyuk commented Jul 29, 2024

Fixed by #1081, merged!

@paulyuk paulyuk closed this as completed Jul 29, 2024
@github-project-automation github-project-automation bot moved this from Needs Owner to Done in v1.14 Release Tracking Board Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/javascript Pull requests that update Javascript code P1
Projects
Development

Successfully merging a pull request may close this issue.

2 participants