Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better expose native WebDriver #18

Open
alechenninger opened this issue Aug 1, 2014 · 2 comments
Open

Better expose native WebDriver #18

alechenninger opened this issue Aug 1, 2014 · 2 comments

Comments

@alechenninger
Copy link
Member

All relevant classes implement WrapsDriver or WrapsElement, however the drivers and elements they wrap are themselves wrapping drivers and elements, who are also wrapping drivers and elements.

So the question is:

  • Should getWrappedDriver return whatever subclass of WebDriver that class is using? Or should it attempt to get at the real Selenium WebDriver that is powering everything? If user wants the real driver (and the interfaces to go with it), what is the best way to expose this?

Same for WebElements.

@alechenninger
Copy link
Member Author

This is still relevant, however drivers and elements are significantly less "layered" since recent refactoring.

@alechenninger alechenninger removed this from the 0.2 milestone Nov 23, 2015
@alechenninger alechenninger changed the title How to best expose underlying WebDriver/WebElement? Better expose native WebDriver Jul 26, 2016
@alechenninger
Copy link
Member Author

I think this is a okay first step:

  • Make TargetedWebDriver extend WrapsDriver
  • Rename WrapsTargetedWebDriver#getWrappedDriver to getWrappedTargetedDriver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant