Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cant set env vars on 2.0.0 #28

Open
burabure opened this issue Jul 28, 2015 · 5 comments
Open

cant set env vars on 2.0.0 #28

burabure opened this issue Jul 28, 2015 · 5 comments

Comments

@burabure
Copy link

I think this is because of the switch to exec.

this used to work:
parallelshell \"NODE_ENV=development nodemon index.js\" \"node webpack-server.js\" \"npm run watch\"

now it throws

parallelshell "export NODE_ENV=development && nodemon index.js"  "node webpack-server.js" "npm run watch"

sh: 1: exec: export: not found
....
@keithamus
Copy link
Collaborator

Hey @burabure thanks for the issue.

You could always run it this way instead:

NODE_ENV=development parallelshell \"nodemon index.js\" \"node webpack-server.js\" \"npm run watch\"

@paulpflug I think we should look at another solution. Possibly revert 2.0.0?

@paulpflug
Copy link
Collaborator

I think so too..
Maybe we have to take the kill by pgid route.
But first I will add more tests with ENV, &&, nesting and everything.

Am 28. Juli 2015 23:36:27 schrieb Keith Cirkel [email protected]:

Hey @burabure thanks for the issue.

You could always run it this way instead:

NODE_ENV=development parallelshell \"nodemon index.js\" \"node 
webpack-server.js\" \"npm run watch\"

@paulpflug I think we should look at another solution. Possibly revert 2.0.0?


Reply to this email directly or view it on GitHub:
#28 (comment)

@keithamus
Copy link
Collaborator

👍

@paulpflug
Copy link
Collaborator

@burabure could you try the version on dev branch?

@hagaigold
Copy link

hagaigold commented Jul 20, 2018

@darkguy2008 , let me know if this is something of interest to this module:
a very simple implementation for supporting env vars - fc75e08

there is already a module for this, cross-env, that does it much better.
so if someone need more complicate parsing, he can always combine the two: calling from parallelshell to cross-env or the other way around.

anyway, I add it with an experimental flag, so it should not create a breaking change (hopefully).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants