Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failing on 64-bit int changes, formatting changes #114

Open
whesse opened this issue Mar 12, 2018 · 0 comments
Open

Test failing on 64-bit int changes, formatting changes #114

whesse opened this issue Mar 12, 2018 · 0 comments
Labels
bug

Comments

@whesse
Copy link

whesse commented Mar 12, 2018

Three tests are failing, when the SDK used to test rpc is updated to the latest.
Two of them are failing because of "invalid 64-bit int" issues. The handling of ints in Dart has changed to 64-bit ints, I believe.
The third is failing because the formatting of generated code changed: the line breaks have moved.
It looks like the expected text needs to be changed.

A builder showing the 3 failures is
https://luci-milo.appspot.com/buildbot/client.dart.packages/packages-mac-rpc/1183
@whesse whesse added the bug label Mar 12, 2018
@jakobr-google jakobr-google self-assigned this Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whesse @jakobr-google