Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Convert Enum Casing during translation. #270

Open
mhevery opened this issue Aug 26, 2015 · 6 comments
Open

Convert Enum Casing during translation. #270

mhevery opened this issue Aug 26, 2015 · 6 comments

Comments

@mhevery
Copy link

mhevery commented Aug 26, 2015 

enum Color { Red, Green, Blue, LightBlue};

in dart it should be

enum Color { red, green, blue, lightBlue }

Because this change will break the API for our customers, we should do this soon.
@mhevery
Copy link
Author

mhevery commented Aug 26, 2015

Turns out I was wrong No action needed: https://www.dartlang.org/articles/style-guide/

@mhevery mhevery closed this as completed Aug 26, 2015
@vicb
Copy link
Contributor

vicb commented Aug 26, 2015

Shouldn't they be lowerCamelCase in Dart - red, lightBlue ?

mhevery added a commit to mhevery/angular that referenced this issue Aug 26, 2015
@mhevery
chore: Make enum names consistent with TypeScript convention
cb74732 
BREAKING_CHANGE

Ts2Dart issue: dart-archive/ts2dart#270
TypeScript convention: https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines
DartConvertion: https://www.dartlang.org/articles/style-guide/

Rename:

- NumberFormatStyle.DECIMAL => NumberFormatStyle.Decimal
- NumberFormatStyle.PERCENT => NumberFormatStyle.Percent
- NumberFormatStyle.CURRENCY => NumberFormatStyle.Currency
- RequestMethods.GET => RequestMethods.Get
- RequestMethods.POST => RequestMethods.Post
- RequestMethods.PUT => RequestMethods.Put
- RequestMethods.DELETE => RequestMethods.Delete
- RequestMethods.HEAD => RequestMethods.Head
- RequestMethods.PATCH => RequestMethods.Patch
- ReadyStates.UNSENT => ReadyStates.Unsent
- ReadyStates.OPEN => ReadyStates.Open
- ReadyStates.HEADERS_RECEIVED => ReadyStates.HeadersReceived
- ReadyStates.LOADING => ReadyStates.Loading
- ReadyStates.DONE => ReadyStates.Done
- ReadyStates.CANCELLED => ReadyStates.Canceled
mhevery added a commit to mhevery/angular that referenced this issue Aug 26, 2015
@mhevery
chore: Make enum names consistent with TypeScript convention
29bf4a7 
BREAKING_CHANGE

Ts2Dart issue: dart-archive/ts2dart#270
TypeScript convention: https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines
DartConvertion: https://www.dartlang.org/articles/style-guide/

Rename:

- NumberFormatStyle.DECIMAL => NumberFormatStyle.Decimal
- NumberFormatStyle.PERCENT => NumberFormatStyle.Percent
- NumberFormatStyle.CURRENCY => NumberFormatStyle.Currency
- RequestMethods.GET => RequestMethods.Get
- RequestMethods.POST => RequestMethods.Post
- RequestMethods.PUT => RequestMethods.Put
- RequestMethods.DELETE => RequestMethods.Delete
- RequestMethods.HEAD => RequestMethods.Head
- RequestMethods.PATCH => RequestMethods.Patch
- ReadyStates.UNSENT => ReadyStates.Unsent
- ReadyStates.OPEN => ReadyStates.Open
- ReadyStates.HEADERS_RECEIVED => ReadyStates.HeadersReceived
- ReadyStates.LOADING => ReadyStates.Loading
- ReadyStates.DONE => ReadyStates.Done
- ReadyStates.CANCELLED => ReadyStates.Canceled
mhevery added a commit to mhevery/angular that referenced this issue Aug 26, 2015
@mhevery
chore: Make enum names consistent with TypeScript convention
61bf33c 
BREAKING_CHANGE

Ts2Dart issue: dart-archive/ts2dart#270
TypeScript convention: https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines
DartConvertion: https://www.dartlang.org/articles/style-guide/

Rename:

- NumberFormatStyle.DECIMAL => NumberFormatStyle.Decimal
- NumberFormatStyle.PERCENT => NumberFormatStyle.Percent
- NumberFormatStyle.CURRENCY => NumberFormatStyle.Currency
- RequestMethods.GET => RequestMethods.Get
- RequestMethods.POST => RequestMethods.Post
- RequestMethods.PUT => RequestMethods.Put
- RequestMethods.DELETE => RequestMethods.Delete
- RequestMethods.HEAD => RequestMethods.Head
- RequestMethods.PATCH => RequestMethods.Patch
- ReadyStates.UNSENT => ReadyStates.Unsent
- ReadyStates.OPEN => ReadyStates.Open
- ReadyStates.HEADERS_RECEIVED => ReadyStates.HeadersReceived
- ReadyStates.LOADING => ReadyStates.Loading
- ReadyStates.DONE => ReadyStates.Done
- ReadyStates.CANCELLED => ReadyStates.Canceled
mhevery added a commit to mhevery/angular that referenced this issue Aug 27, 2015
@mhevery
chore: Make enum names consistent with TypeScript convention
e434f94 
BREAKING_CHANGE

Ts2Dart issue: dart-archive/ts2dart#270
TypeScript convention: https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines
DartConvertion: https://www.dartlang.org/articles/style-guide/

Rename:

- NumberFormatStyle.DECIMAL => NumberFormatStyle.Decimal
- NumberFormatStyle.PERCENT => NumberFormatStyle.Percent
- NumberFormatStyle.CURRENCY => NumberFormatStyle.Currency
- RequestMethods.GET => RequestMethods.Get
- RequestMethods.POST => RequestMethods.Post
- RequestMethods.PUT => RequestMethods.Put
- RequestMethods.DELETE => RequestMethods.Delete
- RequestMethods.HEAD => RequestMethods.Head
- RequestMethods.PATCH => RequestMethods.Patch
- ReadyStates.UNSENT => ReadyStates.Unsent
- ReadyStates.OPEN => ReadyStates.Open
- ReadyStates.HEADERS_RECEIVED => ReadyStates.HeadersReceived
- ReadyStates.LOADING => ReadyStates.Loading
- ReadyStates.DONE => ReadyStates.Done
- ReadyStates.CANCELLED => ReadyStates.Canceled
mhevery added a commit to mhevery/angular that referenced this issue Aug 27, 2015
@mhevery
chore: Make enum names consistent with TypeScript convention
0d7d6bf 
BREAKING_CHANGE

Ts2Dart issue: dart-archive/ts2dart#270
TypeScript convention: https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines
DartConvertion: https://www.dartlang.org/articles/style-guide/

Rename:

- NumberFormatStyle.DECIMAL => NumberFormatStyle.Decimal
- NumberFormatStyle.PERCENT => NumberFormatStyle.Percent
- NumberFormatStyle.CURRENCY => NumberFormatStyle.Currency
- RequestMethods.GET => RequestMethods.Get
- RequestMethods.POST => RequestMethods.Post
- RequestMethods.PUT => RequestMethods.Put
- RequestMethods.DELETE => RequestMethods.Delete
- RequestMethods.HEAD => RequestMethods.Head
- RequestMethods.PATCH => RequestMethods.Patch
- ReadyStates.UNSENT => ReadyStates.Unsent
- ReadyStates.OPEN => ReadyStates.Open
- ReadyStates.HEADERS_RECEIVED => ReadyStates.HeadersReceived
- ReadyStates.LOADING => ReadyStates.Loading
- ReadyStates.DONE => ReadyStates.Done
- ReadyStates.CANCELLED => ReadyStates.Canceled
mhevery added a commit to mhevery/angular that referenced this issue Aug 28, 2015
@mhevery
chore: Make enum names consistent with TypeScript convention
a94d38a 
BREAKING_CHANGE

Ts2Dart issue: dart-archive/ts2dart#270
TypeScript convention: https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines
DartConvertion: https://www.dartlang.org/articles/style-guide/

Rename:

- NumberFormatStyle.DECIMAL => NumberFormatStyle.Decimal
- NumberFormatStyle.PERCENT => NumberFormatStyle.Percent
- NumberFormatStyle.CURRENCY => NumberFormatStyle.Currency
- RequestMethods.GET => RequestMethods.Get
- RequestMethods.POST => RequestMethods.Post
- RequestMethods.PUT => RequestMethods.Put
- RequestMethods.DELETE => RequestMethods.Delete
- RequestMethods.HEAD => RequestMethods.Head
- RequestMethods.PATCH => RequestMethods.Patch
- ReadyStates.UNSENT => ReadyStates.Unsent
- ReadyStates.OPEN => ReadyStates.Open
- ReadyStates.HEADERS_RECEIVED => ReadyStates.HeadersReceived
- ReadyStates.LOADING => ReadyStates.Loading
- ReadyStates.DONE => ReadyStates.Done
- ReadyStates.CANCELLED => ReadyStates.Canceled
mhevery added a commit to mhevery/angular that referenced this issue Aug 28, 2015
@mhevery
chore: Make enum names consistent with TypeScript convention
5799b75 
BREAKING_CHANGE

Ts2Dart issue: dart-archive/ts2dart#270
TypeScript convention: https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines
DartConvertion: https://www.dartlang.org/articles/style-guide/

Rename:

- NumberFormatStyle.DECIMAL => NumberFormatStyle.Decimal
- NumberFormatStyle.PERCENT => NumberFormatStyle.Percent
- NumberFormatStyle.CURRENCY => NumberFormatStyle.Currency
- RequestMethods.GET => RequestMethods.Get
- RequestMethods.POST => RequestMethods.Post
- RequestMethods.PUT => RequestMethods.Put
- RequestMethods.DELETE => RequestMethods.Delete
- RequestMethods.HEAD => RequestMethods.Head
- RequestMethods.PATCH => RequestMethods.Patch
- ReadyStates.UNSENT => ReadyStates.Unsent
- ReadyStates.OPEN => ReadyStates.Open
- ReadyStates.HEADERS_RECEIVED => ReadyStates.HeadersReceived
- ReadyStates.LOADING => ReadyStates.Loading
- ReadyStates.DONE => ReadyStates.Done
- ReadyStates.CANCELLED => ReadyStates.Canceled
mhevery added a commit to angular/angular that referenced this issue Aug 28, 2015
@mhevery
chore: Make enum names consistent with TypeScript convention
37b042b 
BREAKING_CHANGE

Ts2Dart issue: dart-archive/ts2dart#270
TypeScript convention: https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines
DartConvertion: https://www.dartlang.org/articles/style-guide/

Rename:

- NumberFormatStyle.DECIMAL => NumberFormatStyle.Decimal
- NumberFormatStyle.PERCENT => NumberFormatStyle.Percent
- NumberFormatStyle.CURRENCY => NumberFormatStyle.Currency
- RequestMethods.GET => RequestMethods.Get
- RequestMethods.POST => RequestMethods.Post
- RequestMethods.PUT => RequestMethods.Put
- RequestMethods.DELETE => RequestMethods.Delete
- RequestMethods.HEAD => RequestMethods.Head
- RequestMethods.PATCH => RequestMethods.Patch
- ReadyStates.UNSENT => ReadyStates.Unsent
- ReadyStates.OPEN => ReadyStates.Open
- ReadyStates.HEADERS_RECEIVED => ReadyStates.HeadersReceived
- ReadyStates.LOADING => ReadyStates.Loading
- ReadyStates.DONE => ReadyStates.Done
- ReadyStates.CANCELLED => ReadyStates.Canceled
@mhevery
Copy link
Author

mhevery commented Aug 31, 2015

@vicb Dart seems to be inconsistent, we no strong preference. I have discussed this with @yjbanov and we decided that PascalCase is fine. We can't have it both ways without significant changes to ts2dart.

@yjbanov
Copy link
Contributor

yjbanov commented Aug 31, 2015

@mhevery Dart style guide is pretty clear that constant names should be lowerCamelCase. PascalCase would be fine in the style guide recommended so. ts2dart already supports type-based symbol rewriting. It shouldn't be a significant change to ts2dart. Reopening.

@yjbanov yjbanov reopened this Aug 31, 2015
@yjbanov
Copy link
Contributor

yjbanov commented Aug 31, 2015

Updated the issue description.

@mprobst
Copy link
Contributor

mprobst commented Sep 8, 2015

Are you really sure it's a good idea to rename enums, for usability reasons? I'd expect that to cause more confusion than to do good.

Outside of that, the Angular code base is not completely well-typed, i.e. it doesn't pass noImplicitAny. That means we'd have to outlaw any property name that could also be an enum name, so this seems difficult at this point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mprobst @mhevery @yjbanov @vicb