Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

co19 minor improvements #2119

Open
sgrekhov opened this issue Jul 7, 2023 · 0 comments
Open

co19 minor improvements #2119

sgrekhov opened this issue Jul 7, 2023 · 0 comments
Assignees
@sgrekhov
Labels
type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-documentation A request to add or improve documentation

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Jul 7, 2023

Placeholder issue for minor co19 improvements (code formatting, assertion/description wording fixes, adding issue numbers etc)
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Jul 7, 2023
@sgrekhov sgrekhov self-assigned this Jul 7, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 7, 2023
@sgrekhov
dart-lang#2119. Minor wording changes
5e2a9f5
eernstg pushed a commit that referenced this issue Jul 7, 2023
@sgrekhov
#2119. Minor wording changes (#2120)
3ee213d
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 14, 2023
@sgrekhov @athomas
[co19] Roll co19 to 7e4ba229fecce1affe8284b166744329182feb3e
7f42498 
2023-07-14 [email protected] Fixes dart-lang/co19#2132. Fix roll failures, add issue numbers (dart-lang/co19#2134)
2023-07-13 [email protected] Fixes dart-lang/co19#2130. Fix roll failures, add issues numbers (dart-lang/co19#2131)
2023-07-13 [email protected] Fixes dart-lang/co19#2125. Add more external functions tests (dart-lang/co19#2128)
2023-07-13 [email protected] Fixes dart-lang/co19#2087. Reorder covariance tests to make maintenance easier (dart-lang/co19#2129)
2023-07-12 [email protected] dart-lang/co19#2087. Add tests for parameters covariant-by-declaration (dart-lang/co19#2121)
2023-07-12 [email protected] Fixes dart-lang/co19#2117. Update assertions, add tests for external members (dart-lang/co19#2126)
2023-07-12 [email protected] Fixes dart-lang/co19#2123. Update Superclasses tests. (dart-lang/co19#2124)
2023-07-11 [email protected] dart-lang/co19#2117. Update accessible_instance_member_t* tests (dart-lang/co19#2122)
2023-07-10 [email protected] Fixes dart-lang/co19#2099. Add subtyping tests for function type with required named arguments (dart-lang/co19#2100)
2023-07-10 [email protected] dart-lang/co19#2112. Add missing tests for mixins. Part 2 (dart-lang/co19#2118)
2023-07-07 [email protected] dart-lang/co19#2119. Minor wording changes (dart-lang/co19#2120)

Change-Id: I310f2e0a660ac55a242bb9b2ed9a2f1917555d0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313562
Reviewed-by: Alexander Thomas <[email protected]>
osa1 pushed a commit to osa1/sdk that referenced this issue Jul 17, 2023
@sgrekhov @osa1
[co19] Roll co19 to 7e4ba229fecce1affe8284b166744329182feb3e
772c491 
2023-07-14 [email protected] Fixes dart-lang/co19#2132. Fix roll failures, add issue numbers (dart-lang/co19#2134)
2023-07-13 [email protected] Fixes dart-lang/co19#2130. Fix roll failures, add issues numbers (dart-lang/co19#2131)
2023-07-13 [email protected] Fixes dart-lang/co19#2125. Add more external functions tests (dart-lang/co19#2128)
2023-07-13 [email protected] Fixes dart-lang/co19#2087. Reorder covariance tests to make maintenance easier (dart-lang/co19#2129)
2023-07-12 [email protected] dart-lang/co19#2087. Add tests for parameters covariant-by-declaration (dart-lang/co19#2121)
2023-07-12 [email protected] Fixes dart-lang/co19#2117. Update assertions, add tests for external members (dart-lang/co19#2126)
2023-07-12 [email protected] Fixes dart-lang/co19#2123. Update Superclasses tests. (dart-lang/co19#2124)
2023-07-11 [email protected] dart-lang/co19#2117. Update accessible_instance_member_t* tests (dart-lang/co19#2122)
2023-07-10 [email protected] Fixes dart-lang/co19#2099. Add subtyping tests for function type with required named arguments (dart-lang/co19#2100)
2023-07-10 [email protected] dart-lang/co19#2112. Add missing tests for mixins. Part 2 (dart-lang/co19#2118)
2023-07-07 [email protected] dart-lang/co19#2119. Minor wording changes (dart-lang/co19#2120)

Change-Id: I310f2e0a660ac55a242bb9b2ed9a2f1917555d0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313562
Reviewed-by: Alexander Thomas <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 25, 2023
@sgrekhov
dart-lang#2119. Code format and description update in operator tests
af7bdda
eernstg pushed a commit that referenced this issue Aug 25, 2023
@sgrekhov
#2119. Code format and description update in operator tests (#2238)
2703b51 
Code format and description update in operator tests. Note that many of these tests have intentional syntax errors.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Sep 4, 2023
@sgrekhov @athomas
[co19] Roll co19 to ea1107d66f543f79ce865522ddd63718c8eb109e
4d9bfa2 
2023-09-04 [email protected] dart-lang/co19#2145. Fix roll failure (LateInitializationError) (dart-lang/co19#2257)
2023-09-04 [email protected] dart-lang/co19#2145. Add more local variable declaration tests (dart-lang/co19#2254)
2023-09-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (dart-lang/co19#2256)
2023-09-01 [email protected] dart-lang/co19#2213. Fix stack trace comparison (dart-lang/co19#2255)
2023-09-01 [email protected] dart-lang/co19#2145. Update variables tests according to the current spec. Part 2 (dart-lang/co19#2240)
2023-08-31 [email protected] dart-lang/co19#2242. Add LFCR line ending test (dart-lang/co19#2251)
2023-08-31 [email protected] dart-lang/co19#2145. Rename Local Variable declaration tests. Delete duplicates (dart-lang/co19#2252)
2023-08-30 [email protected] dart-lang/co19#2242. Add line endings tests (dart-lang/co19#2250)
2023-08-30 [email protected] Fixes dart-lang/co19#2245. Fix expectations in static_analysis_extension_types_A24_t02.dart (dart-lang/co19#2248)
2023-08-30 [email protected] dart-lang/co19#2242. Change CRLF line endings to LF (dart-lang/co19#2249)
2023-08-30 [email protected] Fixes dart-lang/co19#2244. Fix typo in dynamic_semantics_member_invocation_A01_t02.dart (dart-lang/co19#2247)
2023-08-30 [email protected] Fixes dart-lang/co19#2243. Remove duplicated constructors (dart-lang/co19#2246)
2023-08-29 [email protected] dart-lang/co19#2145. Update assertions and descriptions in the current Local variable declaration tests (dart-lang/co19#2241)
2023-08-25 [email protected] Fixes dart-lang/co19#2235. Add missing operator tests (dart-lang/co19#2239)
2023-08-25 [email protected] dart-lang/co19#2119. Code format and description update in operator tests (dart-lang/co19#2238)

Change-Id: I5aeac05c1aa4cbaa0762ce4f23c1ee916d1006a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324040
Reviewed-by: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-documentation A request to add or improve documentation and removed type-enhancement A request for a change that isn't a bug labels Sep 6, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 7, 2023
@sgrekhov
dart-lang#2119. Run dart formatter on LibTest/async tests
fc43ad2
eernstg pushed a commit that referenced this issue Dec 7, 2023
@sgrekhov
#2119. Run dart formatter on LibTest/async tests (#2417)
579fed7
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 11, 2023
@sgrekhov
[co19] Roll co19 to ea5e476b3af94f74f6996e4b4319bf03f9248c1c
8763ece 
2023-12-07 [email protected] Fixes dart-lang/co19#2413. Add missing expected compile-time errors for CFE (dart-lang/co19#2418)
2023-12-07 [email protected] dart-lang/co19#2119. Run dart formatter on LibTest/async tests (dart-lang/co19#2417)
2023-12-06 [email protected] dart-lang/co19#2398. Make asyncStart/End() safe in LibTest/async (dart-lang/co19#2416)
2023-12-06 [email protected] Fixes dart-lang/co19#2355. Add more typed_date.setRange() tests (dart-lang/co19#2412)
2023-12-06 [email protected] dart-lang/co19#2404. Small code-style improvements and description update (dart-lang/co19#2414)
2023-12-04 [email protected] dart-lang/co19#2004. Add deferred libraries tests according to the changed spec (dart-lang/co19#2411)
2023-12-04 [email protected] Fixes dart-lang/co19#2383. Add more constant evaluation tests (dart-lang/co19#2396)

Change-Id: I15e0d681538fa0f2a311f74d1930fad7270b81a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340561
Commit-Queue: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jan 10, 2024
@sgrekhov
dart-lang#2119. Fix typo and improve error messages in Timer tests
c1845b1
eernstg pushed a commit that referenced this issue Jan 10, 2024
@sgrekhov
#2119. Fix typo and improve error messages in Timer tests (#2473)
a8fb220
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jan 10, 2024
@sgrekhov
dart-lang#2119. Add missing experimental flags
1c8cf93
eernstg pushed a commit that referenced this issue Jan 10, 2024
@sgrekhov
#2119. Add missing experimental flags (#2474)
e58b0f1
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jan 12, 2024
@sgrekhov
[co19] Roll co19 to b5126f0bd51ea0819df8d5c362574f951a564940
f02b056 
2024-01-12 [email protected] Fixes dart-lang/co19#2480. Fix typos, add issue numbers (dart-lang/co19#2481)
2024-01-10 [email protected] dart-lang/co19#2477. Rename and reorder existing constants tests for match operators before adding new ones (dart-lang/co19#2478)
2024-01-10 [email protected] dart-lang/co19#2420. Add null-check-pattern tests for extension types (dart-lang/co19#2475)
2024-01-10 [email protected] dart-lang/co19#2119. Add missing experimental flags (dart-lang/co19#2474)
2024-01-10 [email protected] dart-lang/co19#2119. Fix typo and improve error messages in Timer tests (dart-lang/co19#2473)
2024-01-09 [email protected] Fixes dart-lang/co19#2471. Fix timer constructor tests. Add check for microtasks (dart-lang/co19#2472)
2024-01-09 [email protected] Fixes dart-lang/co19#2428. Add `call` member tests for extension types (dart-lang/co19#2438)
2024-01-09 [email protected] Fixes dart-lang/co19#2449. Update positions of analyzer expected errors (dart-lang/co19#2450)
2024-01-09 [email protected] Fixes dart-lang/co19#2440. Add asyncStart/End() to Stream interface tests (dart-lang/co19#2457)
2024-01-09 [email protected] dart-lang/co19#2420. Add another variable pattern exhaustiveness test (dart-lang/co19#2469)
2024-01-08 [email protected] dart-lang/co19#2420. Add constant pattern exhaustiveness tests (dart-lang/co19#2467)
2024-01-08 [email protected] dart-lang/co19#2436. Add expected constant evaluation error for CFE (dart-lang/co19#2470)
2024-01-08 [email protected] dart-lang/co19#2420. Add null-assert pattern exhaustiveness tests (dart-lang/co19#2468)
2024-01-05 [email protected] dart-lang/co19#2420. Add parenthesized pattern exhaustiveness tests (dart-lang/co19#2464)

Change-Id: I86862732cca7c042120bf312403279c2cc10c135
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345960
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jan 29, 2024
@sgrekhov
dart-lang#2119. Fix typo in Subtyping tests description
b3cc428
eernstg pushed a commit that referenced this issue Jan 29, 2024
@sgrekhov
#2119. Fix typo in Subtyping tests description (#2510)
6e2b5ec
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 5, 2024
@sgrekhov
[co19] Roll co19 to d1ce99fc64d3766ec7dd82362cf80192262822ec
4cc0743 
2024-02-02 [email protected] Fix dart-lang/co19#2517. Fix wrong test, add experimental flags (dart-lang/co19#2518)
2024-02-02 [email protected] Fix dart-lang/co19#2490. Update incompatible with await tests according to the changed rule (dart-lang/co19#2516)
2024-02-01 [email protected] dart-lang/co19#2420. Add more exhaustiveness tests (dart-lang/co19#2513)
2024-01-31 [email protected] dart-lang/co19#2446. Add additional test for cast pattern (dart-lang/co19#2514)
2024-01-30 [email protected] dart-lang/co19#1399. Add more tests for records (dart-lang/co19#2511)
2024-01-30 [email protected] dart-lang/co19#2485. Update map and list constant literals tests. Add parenthesized for records (dart-lang/co19#2512)
2024-01-29 [email protected] Fixes dart-lang/co19#2490. Add more await tests for extension types (dart-lang/co19#2500)
2024-01-29 [email protected] dart-lang/co19#2119. Fix typo in Subtyping tests description (dart-lang/co19#2510)
2024-01-29 [email protected] Fixes dart-lang/co19#2505. Add more tests for `call` member (dart-lang/co19#2506)
2024-01-29 [email protected] dart-lang/co19#2420. Add cast-pattern tests for extension types (dart-lang/co19#2458)

Change-Id: I631705a013f9a77910ae0f0be5a9fea01e7c719f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350240
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: William Hesse <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 9, 2024
@sgrekhov
dart-lang#2119. Remove unused code, add issues numbers
b74e09e
eernstg pushed a commit that referenced this issue Feb 9, 2024
@sgrekhov
#2119. Remove unused code, add issues numbers (#2534)
2ec352f
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 13, 2024
@sgrekhov
dart-lang#2119. Remove unsupported element from Stream.first/lastWher…
ac68368 
…e tests description
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 13, 2024
@sgrekhov
dart-lang#2119. Remove unsupported element from ReceivePort.first/las…
761f34a 
…tWhere tests description
eernstg pushed a commit that referenced this issue Feb 13, 2024
@sgrekhov
#2119. Remove unsupported element from ReceivePort.first/lastWhere te…
90c6230 
…sts description (#2541)
eernstg pushed a commit that referenced this issue Feb 13, 2024
@sgrekhov
#2119. Remove unsupported element from Stream.first/lastWhere tests d…
1e2e66f 
…escription (#2540)
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#2119. Fix typo in Subtyping tests description (dart-lang#2510)
7960712
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#2119. Remove unused code, add issues numbers (dart-lang#2534)
76c94f5
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#2119. Remove unsupported element from ReceivePort.first/las…
78361d4 
…tWhere tests description (dart-lang#2541)
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#2119. Remove unsupported element from Stream.first/lastWher…
fcca6b1 
…e tests description (dart-lang#2540)
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#2119. Fix typo in Subtyping tests description (dart-lang#2510)
f706271
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#2119. Remove unused code, add issues numbers (dart-lang#2534)
6654dee
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#2119. Remove unsupported element from ReceivePort.first/las…
2dc4b73 
…tWhere tests description (dart-lang#2541)
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#2119. Remove unsupported element from Stream.first/lastWher…
b0ee046 
…e tests description (dart-lang#2540)
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 21, 2024
@sgrekhov
[co19] Roll co19 to 867d139b3169fc131488e893ec1133dc98cc3aa0
5e83b53 
2024-02-20 [email protected] dart-lang/co19#2496. Add missing part file (dart-lang/co19#2552)
2024-02-20 [email protected] dart-lang/co19#2549. Update built-in identifier tests. Add missing ones. Part 2 (dart-lang/co19#2551)
2024-02-20 [email protected] dart-lang/co19#2549. Update built-in identifier tests. Add missing ones. Part 1 (dart-lang/co19#2550)
2024-02-19 [email protected] Fix dart-lang/co19#2546. Add constant context tests (dart-lang/co19#2547)
2024-02-15 [email protected] Fixes dart-lang/co19#2496. Fix co19 tests that became failing after test runner update (dart-lang/co19#2497)
2024-02-14 [email protected] dart-lang/co19#1400. Add cascade operator test and more constants tests (dart-lang/co19#2545)
2024-02-14 [email protected] dart-lang/co19#2350. Add more factory constructor tests (dart-lang/co19#2543)
2024-02-14 [email protected] dart-lang/co19#1400. Add representation variable initialization test (dart-lang/co19#2544)
2024-02-13 [email protected] dart-lang/co19#2119. Remove unsupported element from Stream.first/lastWhere tests description (dart-lang/co19#2540)
2024-02-13 [email protected] dart-lang/co19#2119. Remove unsupported element from ReceivePort.first/lastWhere tests description (dart-lang/co19#2541)
2024-02-13 [email protected] dart-lang/co19#2339. Add more tests for the extension method with the name `type` (dart-lang/co19#2542)
2024-02-12 [email protected] Fix dart-lang/co19#2535. Add patterns constants tests for extension types (dart-lang/co19#2539)
2024-02-12 [email protected] Fix dart-lang/co19#2485. Update`as` and `is` expressions tests with a function type (dart-lang/co19#2538)
2024-02-12 [email protected] Fix dart-lang/co19#2536. Fix use of HINT.UNREACHABLE_SWITCH_CASE (dart-lang/co19#2537)
2024-02-09 [email protected] dart-lang/co19#2119. Remove unused code, add issues numbers (dart-lang/co19#2534)
2024-02-09 [email protected] dart-lang/co19#2529. Fix failing API core tests (dart-lang/co19#2533)
2024-02-09 [email protected] dart-lang/co19#2529. Delete API tests with compile-time errors (dart-lang/co19#2531)
2024-02-09 [email protected] dart-lang/co19#2529. Fix and enable Iterable/forEach_A03_t01 (dart-lang/co19#2532)

Change-Id: I03e721d3871d5bf2b9773fbf7ebadb2a1804a111
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353260
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 13, 2024
@sgrekhov
dart-lang#2119. Remove some accidental comments
4287136
eernstg pushed a commit that referenced this issue May 13, 2024
@sgrekhov
#2119. Remove some accidental comments (#2657)
14e8d69
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 17, 2024
@sgrekhov @athomas
[co19] Roll co19 to ce52bad581af26062e8da7bdb0b0c5a5fc89ec7e
c03aa10 
2024-05-16 [email protected] dart-lang/co19#2641. Rename `unchanged` -> `other_declarations` (dart-lang/co19#2670)
2024-05-16 [email protected] dart-lang/co19#2641. Check that it is still an error to declare more than one class member named `_` (dart-lang/co19#2669)
2024-05-15 [email protected] dart-lang/co19#2641. Add tests for multiple top-level declarations named `_` (dart-lang/co19#2667)
2024-05-15 [email protected] dart-lang/co19#2641. Add tests for unchanged type declarations named `_` (dart-lang/co19#2666)
2024-05-14 [email protected] dart-lang/co19#2641. Add tests for unchanged declarations named `_` (dart-lang/co19#2665)
2024-05-14 [email protected] dart-lang/co19#2641. Add tests for multiple declarations named `_` (dart-lang/co19#2656)
2024-05-14 [email protected] Fixes dart-lang/co19#2661. Fix numerous typos in augmented_expression_A01_t09 (dart-lang/co19#2664)
2024-05-14 [email protected] Fixes dart-lang/co19#2659. Make unique extension members names in augmenting_types_A05_t04 (dart-lang/co19#2662)
2024-05-14 [email protected] Fixes dart-lang/co19#2660. Fix typos in augmented_expression_A01_t05 (dart-lang/co19#2663)
2024-05-14 [email protected] dart-lang/co19#2641. Add wildcard initializer tests (dart-lang/co19#2658)
2024-05-13 [email protected] dart-lang/co19#2119. Remove some accidental comments (dart-lang/co19#2657)

Change-Id: I665f56c1039b14354019a32b94183f6d9c9bc5c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367020
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-documentation A request to add or improve documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov