Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for File/Directory/Link.create/createSync() when the path exists #2303

Open
sgrekhov opened this issue Oct 11, 2023 · 0 comments
Open

Add tests for File/Directory/Link.create/createSync() when the path exists #2303

sgrekhov opened this issue Oct 11, 2023 · 0 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

We have co19 tests checking what should happen if we call create/createSync() and FileSystemEntity of the same type exists. But we have no tests checking what will happen when, say, we are creating a File but Directory/Link with the same path exists. Need to test all possible combinations
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Oct 11, 2023
@sgrekhov sgrekhov self-assigned this Oct 11, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 24, 2023
@sgrekhov
dart-lang#2303. Add more File.create() tests
ff1bcae
eernstg pushed a commit that referenced this issue Nov 14, 2023
@sgrekhov
#2303. Add more File.create()/createSync() tests (#2337)
8b30049 
Add more File.create() tests, check all possible parameters, add tests checking file behavior on links, add check if the link is deleted.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 17, 2023
@sgrekhov
[co19] Roll co19 to 460758bf4c298812d47b24f7e5040c75088c3ebf
55a2b1c 
2023-11-17 [email protected] Fixes dart-lang/co19#2381. Fix roll failures (dart-lang/co19#2382)
2023-11-16 [email protected] Fixes dart-lang/co19#2379. Update expected error position for CFE (dart-lang/co19#2380)
2023-11-16 [email protected] Fixes dart-lang/co19#2377. Add missing Float32x4List.setAll_A04_t01 test (dart-lang/co19#2378)
2023-11-16 [email protected] Fixes dart-lang/co19#2373. Expect additional errors in CFE for member conflicts tests (dart-lang/co19#2375)
2023-11-16 [email protected] dart-lang/co19#2359. Fix existing extension types tests according to the new nullability rules (dart-lang/co19#2372)
2023-11-16 [email protected] Fixes dart-lang/co19#2356. Fix nullability in dynamic_semantics_member_invocation_A03_t02.dart (dart-lang/co19#2368)
2023-11-16 [email protected] dart-lang/co19#2371. Add tests for factory constructor generating an enum value (dart-lang/co19#2376)
2023-11-15 [email protected] dart-lang/co19#2371. Add missing enhanced enums tests, update assertions (dart-lang/co19#2374)
2023-11-14 [email protected] Fixes dart-lang/co19#2369. Static type of == operator is always bool (dart-lang/co19#2370)
2023-11-14 [email protected] dart-lang/co19#2303. Add more File.create()/createSync() tests (dart-lang/co19#2337)
2023-11-10 [email protected] dart-lang/co19#2339. Add test for extension named type and a record type (dart-lang/co19#2366)

Change-Id: If608421c5a4f614187a66dc05fa5d8d90c9e363d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336901
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov