From ed26087ae1b54fb8c532fcda618e6bf08827e315 Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Mon, 14 Mar 2022 15:27:11 -0700 Subject: [PATCH] rename `use_super_initializers` to `use_super_parameters` (#3288) --- CHANGELOG.md | 6 +++++ example/all.yaml | 2 +- lib/src/rules.dart | 4 ++-- ...alizers.dart => use_super_parameters.dart} | 14 ++++++------ lib/src/version.dart | 2 +- pubspec.yaml | 2 +- test/rules/all.dart | 4 ++-- ...st.dart => use_super_parameters_test.dart} | 22 +++++++++---------- 8 files changed, 31 insertions(+), 25 deletions(-) rename lib/src/rules/{use_super_initializers.dart => use_super_parameters.dart} (94%) rename test/rules/{use_super_initializers_test.dart => use_super_parameters_test.dart} (89%) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5b56d4493..da82039f8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +# 1.20.0 + +- renamed `use_super_initializers` to `use_super_parameters` +- fixed `unnecessary_null_aware_assignments` property-access + false positive + # 1.19.2 - new lint: `use_super_initializers` diff --git a/example/all.yaml b/example/all.yaml index 70e156c72..24860ca95 100644 --- a/example/all.yaml +++ b/example/all.yaml @@ -200,7 +200,7 @@ linter: - use_rethrow_when_possible - use_setters_to_change_properties - use_string_buffers - - use_super_initializers + - use_super_parameters - use_test_throws_matchers - use_to_and_as_if_applicable - valid_regexps diff --git a/lib/src/rules.dart b/lib/src/rules.dart index 29ed27be3..38244d2f4 100644 --- a/lib/src/rules.dart +++ b/lib/src/rules.dart @@ -204,7 +204,7 @@ import 'rules/use_raw_strings.dart'; import 'rules/use_rethrow_when_possible.dart'; import 'rules/use_setters_to_change_properties.dart'; import 'rules/use_string_buffers.dart'; -import 'rules/use_super_initializers.dart'; +import 'rules/use_super_parameters.dart'; import 'rules/use_test_throws_matchers.dart'; import 'rules/use_to_and_as_if_applicable.dart'; import 'rules/valid_regexps.dart'; @@ -416,7 +416,7 @@ void registerLintRules({bool inTestMode = false}) { ..register(UseRawStrings()) ..register(UseSettersToChangeAProperty()) ..register(UseStringBuffers()) - ..register(UseSuperInitializers()) + ..register(UseSuperParameters()) ..register(UseTestThrowsMatchers()) ..register(UseToAndAsIfApplicable()) ..register(ValidRegExps()) diff --git a/lib/src/rules/use_super_initializers.dart b/lib/src/rules/use_super_parameters.dart similarity index 94% rename from lib/src/rules/use_super_initializers.dart rename to lib/src/rules/use_super_parameters.dart index 74753a5d5..5a250fbc4 100644 --- a/lib/src/rules/use_super_initializers.dart +++ b/lib/src/rules/use_super_parameters.dart @@ -42,15 +42,15 @@ class B extends A { ``` '''; -class UseSuperInitializers extends LintRule { +class UseSuperParameters extends LintRule { static const LintCode singleParam = - LintCode('use_super_initializers', "Convert '{0}' to a super parameter."); + LintCode('use_super_parameters', "Convert '{0}' to a super parameter."); static const LintCode multipleParams = - LintCode('use_super_initializers', 'Convert {0} to super parameters.'); + LintCode('use_super_parameters', 'Convert {0} to super parameters.'); - UseSuperInitializers() + UseSuperParameters() : super( - name: 'use_super_initializers', + name: 'use_super_parameters', description: _desc, details: _details, maturity: Maturity.experimental, @@ -230,10 +230,10 @@ class _Visitor extends SimpleAstVisitor { if (identifiers.length > 1) { var msg = identifiers.quotedAndCommaSeparatedWithAnd; rule.reportLint(target, - errorCode: UseSuperInitializers.multipleParams, arguments: [msg]); + errorCode: UseSuperParameters.multipleParams, arguments: [msg]); } else { rule.reportLint(target, - errorCode: UseSuperInitializers.singleParam, + errorCode: UseSuperParameters.singleParam, arguments: [identifiers.first]); } } diff --git a/lib/src/version.dart b/lib/src/version.dart index 6ad379d9e..5eabb5932 100644 --- a/lib/src/version.dart +++ b/lib/src/version.dart @@ -3,4 +3,4 @@ // BSD-style license that can be found in the LICENSE file. /// Package version. Synchronized w/ pubspec.yaml. -const String version = '1.19.2'; +const String version = '1.20.0'; diff --git a/pubspec.yaml b/pubspec.yaml index 851366f95..73662b393 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: linter -version: 1.19.2 +version: 1.20.0 description: >- The implementation of the lint rules supported by the analyzer framework. diff --git a/test/rules/all.dart b/test/rules/all.dart index 45fdbe4b6..8aa884223 100644 --- a/test/rules/all.dart +++ b/test/rules/all.dart @@ -70,7 +70,7 @@ import 'unnecessary_overrides_test.dart' as unnecessary_overrides; import 'use_enums_test.dart' as use_enums; import 'use_is_even_rather_than_modulo_test.dart' as use_is_even_rather_than_modulo; -import 'use_super_initializers_test.dart' as use_super_initializers; +import 'use_super_parameters_test.dart' as use_super_parameters; import 'void_checks_test.dart' as void_checks; void main() { @@ -120,6 +120,6 @@ void main() { unnecessary_overrides.main(); use_enums.main(); use_is_even_rather_than_modulo.main(); - use_super_initializers.main(); + use_super_parameters.main(); void_checks.main(); } diff --git a/test/rules/use_super_initializers_test.dart b/test/rules/use_super_parameters_test.dart similarity index 89% rename from test/rules/use_super_initializers_test.dart rename to test/rules/use_super_parameters_test.dart index 1a3109fa5..d6684e289 100644 --- a/test/rules/use_super_initializers_test.dart +++ b/test/rules/use_super_parameters_test.dart @@ -8,19 +8,19 @@ import '../rule_test_support.dart'; main() { defineReflectiveSuite(() { - defineReflectiveTests(UseSuperInitializersTest); + defineReflectiveTests(UseSuperParametersTest); }); } @reflectiveTest -class UseSuperInitializersTest extends LintRuleTest { +class UseSuperParametersTest extends LintRuleTest { @override List get experiments => [ EnableString.super_parameters, ]; @override - String get lintRule => 'use_super_initializers'; + String get lintRule => 'use_super_parameters'; test_named() async { await assertDiagnostics(r''' @@ -31,7 +31,7 @@ class B extends A { const B({int? x, int? y}) : super(x: x, y: y); } ''', [ - lint('use_super_initializers', 69, 1), + lint('use_super_parameters', 69, 1), ]); } @@ -182,7 +182,7 @@ class B extends A { B(int x, {int? foo}) : super(x, foo: 0); } ''', [ - lint('use_super_initializers', 59, 1), + lint('use_super_parameters', 59, 1), ]); } @@ -195,7 +195,7 @@ class B extends A { B(int x) : super(x); } ''', [ - lint('use_super_initializers', 56, 1), + lint('use_super_parameters', 56, 1), ]); } @@ -208,7 +208,7 @@ class B extends A { B([int x = 0]) : super(x); } ''', [ - lint('use_super_initializers', 46, 1), + lint('use_super_parameters', 46, 1), ]); } @@ -223,7 +223,7 @@ class C extends B { C(int foo, int bar) : super(foo, bar); } ''', [ - lint('use_super_initializers', 93, 1), + lint('use_super_parameters', 93, 1), ]); } @@ -236,7 +236,7 @@ class B extends A { B(int x, int y) : super(x, y: y); } ''', [ - lint('use_super_initializers', 56, 1), + lint('use_super_parameters', 56, 1), ]); } @@ -251,7 +251,7 @@ class C extends B { C(int baz, int foo, int bar) : super(foo, bar); } ''', [ - lint('use_super_initializers', 93, 1), + lint('use_super_parameters', 93, 1), ]); } @@ -264,7 +264,7 @@ class B extends A { B(int x, {int? y}) : super(x, y: y); } ''', [ - lint('use_super_initializers', 56, 1), + lint('use_super_parameters', 56, 1), ]); } }