Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lint to dissuade users from creating multiple goldens in a single test #4613

Closed
pdblasi-google opened this issue Jul 24, 2023 · 2 comments
Labels
lint-proposal needs-info Additional information needed from the issue author

Comments

@pdblasi-google
Copy link

Golden tests can be pretty flaky in and of themselves, and the flow is made worse when users have multiple goldens in a single test. If a user does that, it means that you'd have to make multiple passes through the test to update each golden. It'd be great to have a lint that drives a user to use AnimationSheetBuilder when multiple golden checks are defined in a single test.

@srawlins
Copy link
Member

Can you explain what goldens you are referring to? Or what a golden check is? Or how AnimationSheetBuilder would disable a diagnostic from being reported?

In order to implement a linter rule, we'd need very specific notions of what code should trigger a diagnostic. Any details would be appreciated. Thanks!

@srawlins srawlins added needs-info Additional information needed from the issue author lint-proposal labels Jul 31, 2023
@github-actions
Copy link

Without additional information we're not able to resolve this issue. Feel free to add more info or respond to any questions above and we can reopen the case. Thanks for your contribution!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lint-proposal needs-info Additional information needed from the issue author
Projects
None yet
Development

No branches or pull requests

2 participants