Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sized_box_for_whitespace inconsistency #5067

Open
nate-thegrate opened this issue Aug 19, 2024 · 0 comments
Open

sized_box_for_whitespace inconsistency #5067

nate-thegrate opened this issue Aug 19, 2024 · 0 comments
Labels
P3 A lower priority bug or feature request set-flutter Affects a rule in the recommended Flutter rule set type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@nate-thegrate
Copy link

The sized_box_for_whitespace rule only activates when the Container has a child, perhaps because swapping out the Container's default LimitedBox child could cause behavioral changes.

But this means that the linter rule's example wouldn't actually trigger the rule:

BAD:

Widget buildRow() {
  return Row(
    children: <Widget>[
      const MyLogo(),
      Container(width: 4),
      const Expanded(
        child: Text('...'),
      ),
    ],
  );
}
@github-actions github-actions bot added the set-flutter Affects a rule in the recommended Flutter rule set label Aug 19, 2024
@srawlins srawlins added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P3 A lower priority bug or feature request labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request set-flutter Affects a rule in the recommended Flutter rule set type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants