Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [co19] Roll co19 to c7f412ab8b0ad444eea4d6dbd7616b475e050fab #53237

Closed
eernstg opened this issue Aug 16, 2023 · 7 comments
Closed

Failures on [co19] Roll co19 to c7f412ab8b0ad444eea4d6dbd7616b475e050fab #53237

eernstg opened this issue Aug 16, 2023 · 7 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@eernstg
Copy link
Member

eernstg commented Aug 16, 2023

There are new test failures on [co19] Roll co19 to c7f412ab8b0ad444eea4d6dbd7616b475e050fab.

The tests

co19/Language/Functions/element_type_A01_t01 MissingCompileTimeError (expected Pass)
co19/Language/Functions/element_type_A01_t02 MissingCompileTimeError (expected Pass)
co19/Language/Functions/element_type_A01_t03 RuntimeError (expected Pass)
co19/Language/Functions/element_type_A01_t04 RuntimeError (expected Pass)
co19/Language/Functions/element_type_A01_t06 RuntimeError (expected Pass)
co19/Language/Functions/element_type_A02_t01 MissingCompileTimeError (expected Pass)
co19/Language/Functions/element_type_A02_t02 MissingCompileTimeError (expected Pass)
co19/Language/Functions/element_type_A02_t03 RuntimeError (expected Pass)
co19/Language/Functions/element_type_A02_t04 RuntimeError (expected Pass)
co19/Language/Functions/element_type_A02_t06 RuntimeError (expected Pass)
co19/Language/Functions/element_type_A03_t02 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/dynamic_semantics_extension_type_A05_t02 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/dynamic_semantics_member_invocation_A02_t04 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/dynamic_semantics_member_invocation_A03_t04 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A08_t02 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A13_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t01 DartkCrash (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t01 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t02 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t02 DartkCrash (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t06 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t07 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A23_t01 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A24_t02 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A24_t02 DartkCrash (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A24_t02 CompileTimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A26_t01 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_member_invocation_A05_t03 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A01_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A01_t02 MissingCompileTimeError (expected Pass)
    and 9 more tests

are failing on configurations

analyzer-asserts-linux
cfe-strong-linux
cfe-weak-linux
dart2js-hostasserts-linux-chrome-unsound
dart2js-hostasserts-linux-d8
dart2js-linux-chrome
dart2wasm-linux-chrome
dart2wasm-linux-d8
ddc-linux-chrome
ddc-linux-chrome-unsound
vm-mac-debug-arm64
vm-mac-release-arm64
@eernstg eernstg mentioned this issue Aug 16, 2023
Closed
@mit-mit mit-mit added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Aug 16, 2023
@sgrekhov
Copy link
Contributor

Triaged

Failure Issue
analyzer-asserts-linux  
new test -> CompileTimeError (expected Pass)  
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A24_t02 #53206
new test -> MissingCompileTimeError (expected Pass)  
co19/Language/Functions/element_type_A01_t01 #53054
co19/Language/Functions/element_type_A01_t02 #53054
co19/Language/Functions/element_type_A02_t01 #53054
co19/Language/Functions/element_type_A02_t02 #53054
cfe...  
MissingCompileTimeError -> Crash (expected Pass)  
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A23_t01 #53212
Pass -> MissingCompileTimeError (expected Pass)  
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A08_t02 #53207
new test -> Crash (expected Pass)  
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t06 #53232
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t07 #53213
new test -> MissingCompileTimeError (expected Pass)  
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A13_t01 #53172
co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A01_t01 #53170
co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A01_t02 #53170
co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A04_t01 #53170
co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A04_t02 #53170
co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A04_t04 #53170
co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A04_t05 #53170
co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A04_t06 #53170
co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A04_t07 #53170
co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A05_t01 #53172
co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A05_t02 #53172
cfe...  
dart2js...  
dart2wasm...  
ddc...  
new test -> Crash (expected Pass)  
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t01 #53140
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t02 #53140
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A24_t02 #53140
cfe...  
dart2js...  
dart2wasm...  
ddc...  
vm...  
new test -> CompileTimeError (expected Pass)  
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A24_t01 #53211
co19/LanguageFeatures/Extension-types/static_analysis_member_invocation_A05_t03 #53211
cfe...dart2js...dart2wasm...new test -> Crash (expected Pass)  
co19/LanguageFeatures/Extension-types/dynamic_semantics_extension_type_A05_t02 #53238
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A26_t01 #53232
   
dart2js...CompileTimeError -> RuntimeError (expected Pass)  
co19/LanguageFeatures/Extension-types/dynamic_semantics_member_invocation_A02_t04 #53233
co19/LanguageFeatures/Extension-types/dynamic_semantics_member_invocation_A03_t04 #53233
dart2js...dart2wasm...ddc...vm…  
new test -> RuntimeError (expected Pass)  
co19/Language/Functions/element_type_A01_t03 #53053
co19/Language/Functions/element_type_A01_t04 #53053
co19/Language/Functions/element_type_A01_t06 #53053
dart2js...dart2wasm-linux-d8ddc...vm…  
new test -> RuntimeError (expected Pass)  
co19/Language/Functions/element_type_A02_t03 #53053
co19/Language/Functions/element_type_A02_t04 #53053
co19/Language/Functions/element_type_A02_t06 #53053
   
dart2wasm...new test -> Crash (expected Pass)  
co19/Language/Functions/element_type_A03_t02 #53234
co19/LanguageFeatures/Extension-types/static_analysis_member_invocation_A05_t03 #53239
vm...  
new test -> DartkCrash (expected Pass)  
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t01 #53140
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t02 #53140
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A24_t02 #53140

@sgrekhov
Copy link
Contributor

Can this issue be closed?

@eernstg
Copy link
Member Author

eernstg commented Aug 17, 2023

I'd say yes, it can be closed: The approved test failures have been annotated in Gerrit with a reference to this issue, but it will still be possible to look at this issue after it has been closed, and this issue contains the links to the more detailed issues where each of the observed faults are described. So the connection from an approved failure to the relevant issue still exists.

@athom, do you agree? Does closing the approval bug automatically unapprove the test failure? (That is, does it cause some automatic procedure to send notifications to owners of the given test libraries that they shouldn't fail any more?)

@athom
Copy link

athom commented Aug 17, 2023

@eernstg
sorry, I believe you cue the wrong person :)

@eernstg
Copy link
Member Author

eernstg commented Aug 17, 2023

I'm sorry @athom!

@athomas, I think I checked the completion more carefully this time. ;-) WDYT?

@athom
Copy link

athom commented Aug 17, 2023

@eernstg
no worries, just make sure someone wont miss your message.
I wish I could have time to learn and use the dart-lang, looks cool. Great work!

@eernstg
Copy link
Member Author

eernstg commented Aug 17, 2023

Thanks for the kind words, @athom! And do take a look at Dart if you get an opportunity! 😄

@athomas athomas closed this as completed Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@athom @sgrekhov @eernstg @mit-mit @athomas