Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enum Shorthands] Core library updates #59876

Open
Tracked by #57036
kallentu opened this issue Jan 9, 2025 · 2 comments
Open
Tracked by #57036

[Enum Shorthands] Core library updates #59876

kallentu opened this issue Jan 9, 2025 · 2 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. feature-enum-shorthands Implementation of the enum shorthands feature.

Comments

@kallentu
Copy link
Member

kallentu commented Jan 9, 2025

This issue tracks the changes we want to make to the core libraries with the enum shorthands feature.

I believe we'll have a lint that converts typed static accesses to enum shorthand form (Color.blue -> .blue). Do we want to change any part of the core libraries to use enum shorthands?
And any other changes we need to make?

cc. @lrhn

@kallentu kallentu added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. feature-enum-shorthands Implementation of the enum shorthands feature. labels Jan 9, 2025
@lrhn
Copy link
Member

lrhn commented Jan 9, 2025

There is no urgency.
This is a shorthand that only affects readability of implementation code, not the API. Nobody should be able to see, or care, whether we use the shorthand or not.

We can choose to use it everywhere it applies, as a style statement, or we can update code when we touch it anyway.
The latter has been our strategy so far, so let's just keep doing that.

@kallentu
Copy link
Member Author

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. feature-enum-shorthands Implementation of the enum shorthands feature.
Projects
None yet
Development

No branches or pull requests

2 participants