-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Linux RISC-V download link for Beta Channel 3.2.0 #5355
Comments
Thanks for opening an issue! I didn't consider this before. @athomas @rmacnak-google @sortie (Feel free to redirect query) This is a rare and temporary situation when stable is released and beta is updated to match (which is useful), but I'm not sure the best way to handle it in the UI when a platform is not yet built for stable. This currently affects Windows ARM64 and Linux RV64GC. Should we:
|
@parlough I've previously spoken to @mit-mit about my desire to have your option 1, though that was before this download issue reared its head. Option 1 remains my preferred approach, as it solves this issue, and facilitates multi platform Docker image manifests where the RISC-V SDK is aligned to the other stable ones. |
Yeah that definitely makes sense to me! Thanks for the extra context. I'll defer to those I pinged though as I'm not personally familiar with the work necessary and I imagine the fix wouldn't be relevant until 3.3.0. |
Yeah. I see the problem. When we publish the new stable, we see it's ahead of beta, and copy it to be the latest beta as well. Unfortunately it did not contain all the experimental platforms. I wrote the publishing code and hadn't thought of this particular case. I don't have a solution at this time. I'll have to think about it. Random early thoughts:
|
The obvious solution seems to be to publish the new beta before publishing the stable? Doesn't have to be long before, just a little bit. |
Not a bad idea, although that was accidentally was done this release which got us in a bit of a bad situation IMO, and what we decided to avoid for future releases. But if it's done after the beta->stable merge, then this could work, though it's a small window and not sure it's practical. |
It wasn't an accident, and there's no workable proposal that avoids this and doesn't have other tradeoffs that we want to avoid. |
Thanks for taking a look and thinking about this! Some thoughts and questions:
I really like the aspect that beta can't be behind stable, even for a short amount of time. The main pain point comes from thinking 3.2.0 is stable and using that as your lower SDK constraint (
I don't have a large opinion on this, as we can explicitly state the support is experimental, but that would be hidden from tooling, so I'm not sure the potential misconceptions would be worth it.
This may not make sense, but is it possible to build a stable version for the experimental platforms, but only include it in the copied beta directories? Might be good to have that extra validation for upcoming platforms?
This makes sense to me as long as the gap isn't too large. What are the downsides for this solution? |
Note that 3.3 beta 1 simply wasn't published. I didn't notice this until today and published it. It should've been published the same day 3.2.0 went out. We'd still have had this issue but only for an hour or so if it had been published when it was intended to be published. |
Reopening -- but actually -- I just realized that all the platforms are now built on stable, so this is a non-problem. However, there still isn't a technical fix in place to prevent this from rehappening if we add new experimental platforms again, but we can do the proposed process fix to publish the next beta before the stable. |
Page URL
https://dart.dev/get-dart/archive
Page source
src/get-dart/archive/index.md
Describe the problem
If I go to the Beta Channel and select Linux as the OS the page presents download links for each of the supported architectures.
x64, IA32, ARMv8 and ARMv7 all link to working URLs
RISC-V yields:
Expected fix
Ensure that RISC-V zip files are created alongside the other architectures.
Additional context
The 3.2.0-210.4.beta package from 1 Nov downloads just fine.
This may be partly due to 3.2.0 becoming stable, and RISC-V not being a supported stable architecture, and is likely to resolve itself as 3.3.0 is promoted from Dev to Beta.
Right now the
versions.json
in the dart-docker repo has stable and beta at parity - same version number and same SHAs:I would like to fix this problem.
The text was updated successfully, but these errors were encountered: