Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deploy project to dart-dev #5449

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Change deploy project to dart-dev #5449

merged 3 commits into from
Jan 4, 2024

Conversation

khanhnwin
Copy link
Contributor

Addresses remaining AI's from #5447.

  • Swapped out deploy project to dart-dev
  • I've manually disabled the deploy.yaml GitHub action workflow from the "Actions" menu.
  • Updated the Cloud Build trigger to go off on push to main branch

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Jan 4, 2024

Visit the preview URL for this PR (updated for commit 9ce7d10):

https://dart-dev--pr5449-remove-deploy-action-bio0y9wf.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khanhnwin!

One request and one question:

cloud_build/deploy.yaml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @khanhnwin!

Consistent staging and deploys here we come. 🚅

@khanhnwin
Copy link
Contributor Author

wahoooo!

@khanhnwin khanhnwin merged commit 351b567 into main Jan 4, 2024
8 checks passed
@parlough parlough deleted the remove-deploy-action branch January 4, 2024 23:52
@khanhnwin
Copy link
Contributor Author

We're good! https://github.com/dart-lang/site-www/runs/20180528321

atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
Addresses remaining AI's from dart-lang#5447.

- [x] Swapped out deploy project to `dart-dev`
- [x] I've manually disabled the [deploy.yaml GitHub
action](https://github.com/dart-lang/site-www/blob/main/.github/workflows/deploy.yml)
workflow from the "Actions" menu.
- [x] Updated the Cloud Build trigger to go off on push to `main` branch
@Khammunh
Copy link

Hi sister can you help me write code scan barcode flutter project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants