Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs: Correct 'argument' to 'parameter', fix whitespace & EOF. #5454

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Update docs: Correct 'argument' to 'parameter', fix whitespace & EOF. #5454

merged 3 commits into from
Jan 9, 2024

Conversation

ath
Copy link
Contributor

@ath ath commented Jan 9, 2024

In some places “argument type” was used and this has been corrected into “parameter type”.
Some trailing whitespaces where removed.
One file didn’t end in a newline and this has been fixed.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn’t contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

@ath
Correct word usage in extend.md.
cd60073 
At this place we talk about the method parameters, not the arguments at the call site. I verified that both, ChatGPT and Bard, agree with this assessment.
@ath
Fix parameter type description in extend.md.
e1a439e
@ath
Fix trailing whitespace issues.
6663e4a
@parlough parlough mentioned this pull request Jan 9, 2024
Closed
@parlough
Copy link
Member

parlough commented Jan 9, 2024

/gcbrun

parlough
parlough approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this fix and cleanup! Looks good to me :)

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 6663e4a):

https://dart-dev--pr5454-ath-zqiidgk4.web.app

@parlough parlough merged commit df2d267 into dart-lang:main Jan 9, 2024
8 checks passed
@ath ath deleted the ath branch January 9, 2024 22:23
atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
@ath @atsansone
Update docs: Correct 'argument' to 'parameter', fix whitespace & EOF. (…
4b330a6 
…dart-lang#5454)

In some places “argument type” was used and this has been corrected into
“parameter type”.
Some trailing whitespaces where removed.
One file didn’t end in a newline and this has been fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ath @parlough @dart-github-bot