Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document external on the Functions page #5478

Closed
Tracked by #5475
MaryaBelanger opened this issue Jan 19, 2024 · 0 comments · Fixed by #5481
Closed
Tracked by #5475

Document external on the Functions page #5478

MaryaBelanger opened this issue Jan 19, 2024 · 0 comments · Fixed by #5481
Assignees
Labels
a.language Relates to the Dart language tour d.enhancement Improves docs with specific ask dev.interop Relates to use of native code as part of your Dart app e1-hours Can complete in < 8 hours of normal, not dedicated, work p1-high Major but not urgent concern: Resolve in months. Update each month.

Comments

@MaryaBelanger
Copy link
Contributor

MaryaBelanger commented Jan 19, 2024

The external keyword isn't explained anywhere on the site. Right now, references of it point to the spec.

With JS interop and extension type docs developing, I think it's important to have a high-level summary of external to point to when we're talking about it.

I think the section should go on the Functions page, and be relatively high-level (description in the spec is good). Since it's highly platform dependent, we can just summarize it and point to interop docs (maybe use C and JS specifically as an example, until we have a interop overview page to point to instead).

@MaryaBelanger MaryaBelanger self-assigned this Jan 19, 2024
@parlough parlough added a.language Relates to the Dart language tour p1-high Major but not urgent concern: Resolve in months. Update each month. e1-hours Can complete in < 8 hours of normal, not dedicated, work dev.interop Relates to use of native code as part of your Dart app d.enhancement Improves docs with specific ask labels Jan 19, 2024
This was referenced Jan 19, 2024
MaryaBelanger added a commit that referenced this issue Jan 31, 2024
Fixes #5478

---------

Co-authored-by: Erik Ernst <[email protected]>
atsansone pushed a commit to atsansone/site-www that referenced this issue Feb 1, 2024
atsansone pushed a commit to atsansone/site-www that referenced this issue Feb 9, 2024
atsansone pushed a commit to atsansone/site-www that referenced this issue Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.language Relates to the Dart language tour d.enhancement Improves docs with specific ask dev.interop Relates to use of native code as part of your Dart app e1-hours Can complete in < 8 hours of normal, not dedicated, work p1-high Major but not urgent concern: Resolve in months. Update each month.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants