From 53dfd4137afe976a8b7181e18261efe5a7e9f93f Mon Sep 17 00:00:00 2001 From: Anna Gringauze Date: Mon, 24 Jul 2023 08:24:35 -0700 Subject: [PATCH] Update SDK min consrraint to require new debugger runtime API --- dwds/debug_extension/pubspec.yaml | 2 +- dwds/debug_extension_mv3/pubspec.yaml | 2 +- dwds/lib/src/debugging/instance.dart | 7 +++---- dwds/pubspec.yaml | 2 +- dwds/test/chrome_proxy_service_test.dart | 1 - example/pubspec.yaml | 2 +- fixtures/_test/pubspec.yaml | 2 +- fixtures/_testCircular1/pubspec.yaml | 2 +- fixtures/_testCircular1Sound/pubspec.yaml | 2 +- fixtures/_testCircular2/pubspec.yaml | 2 +- fixtures/_testCircular2Sound/pubspec.yaml | 2 +- fixtures/_testPackageSound/pubspec.yaml | 2 +- fixtures/_testSound/pubspec.yaml | 2 +- fixtures/_webdevSmoke/pubspec.yaml | 2 +- fixtures/_webdevSoundSmoke/pubspec.yaml | 2 +- webdev/CHANGELOG.md | 1 + webdev/pubspec.yaml | 2 +- 17 files changed, 18 insertions(+), 19 deletions(-) diff --git a/dwds/debug_extension/pubspec.yaml b/dwds/debug_extension/pubspec.yaml index 8dd6ddeda..07cf7ad41 100644 --- a/dwds/debug_extension/pubspec.yaml +++ b/dwds/debug_extension/pubspec.yaml @@ -6,7 +6,7 @@ description: >- A chrome extension for Dart debugging. environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dependencies: async: ^2.3.0 diff --git a/dwds/debug_extension_mv3/pubspec.yaml b/dwds/debug_extension_mv3/pubspec.yaml index f0421f511..2cb77c4f1 100644 --- a/dwds/debug_extension_mv3/pubspec.yaml +++ b/dwds/debug_extension_mv3/pubspec.yaml @@ -6,7 +6,7 @@ description: >- A Chrome extension for Dart debugging. environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dependencies: built_value: ^8.3.0 diff --git a/dwds/lib/src/debugging/instance.dart b/dwds/lib/src/debugging/instance.dart index 4b33a0981..9c1ad3a54 100644 --- a/dwds/lib/src/debugging/instance.dart +++ b/dwds/lib/src/debugging/instance.dart @@ -868,17 +868,16 @@ class InstanceHelper extends Domain { id: objectId, identityHashCode: objectId.hashCode, classRef: classRefForClosure, - // TODO(grouma) - fill this in properly. + // TODO(annagrin) - fill this in properly. closureFunction: FuncRef( name: functionMetaData.name, id: createId(), - // TODO(alanknight): The right ClassRef owner: classRefForUnknown, isConst: false, isStatic: false, - // TODO(annagrin): get information about getters and setters from symbols. - // https://github.com/dart-lang/sdk/issues/46723 implicit: false, + isGetter: false, + isSetter: false, ), closureContext: ContextRef(length: 0, id: createId()), ); diff --git a/dwds/pubspec.yaml b/dwds/pubspec.yaml index 3cd46cbd0..11676531b 100644 --- a/dwds/pubspec.yaml +++ b/dwds/pubspec.yaml @@ -6,7 +6,7 @@ description: >- service protocol. repository: https://github.com/dart-lang/webdev/tree/master/dwds environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dependencies: async: ^2.9.0 diff --git a/dwds/test/chrome_proxy_service_test.dart b/dwds/test/chrome_proxy_service_test.dart index de89b2d1f..8fa93fa1c 100644 --- a/dwds/test/chrome_proxy_service_test.dart +++ b/dwds/test/chrome_proxy_service_test.dart @@ -39,7 +39,6 @@ void main() { await context.setUp( enableExpressionEvaluation: true, verboseCompiler: false, - canaryFeatures: true, ); }); diff --git a/example/pubspec.yaml b/example/pubspec.yaml index 9f1797838..747180c44 100644 --- a/example/pubspec.yaml +++ b/example/pubspec.yaml @@ -4,7 +4,7 @@ description: A web app example for webdev CLI. publish_to: none environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dev_dependencies: build_runner: ^2.4.0 diff --git a/fixtures/_test/pubspec.yaml b/fixtures/_test/pubspec.yaml index 5969c1891..ca7044b90 100644 --- a/fixtures/_test/pubspec.yaml +++ b/fixtures/_test/pubspec.yaml @@ -9,7 +9,7 @@ description: >- publish_to: none environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dependencies: intl: ^0.17.0 diff --git a/fixtures/_testCircular1/pubspec.yaml b/fixtures/_testCircular1/pubspec.yaml index 8fc4b93ee..ce209823c 100644 --- a/fixtures/_testCircular1/pubspec.yaml +++ b/fixtures/_testCircular1/pubspec.yaml @@ -9,7 +9,7 @@ description: >- publish_to: none environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dependencies: intl: ^0.17.0 diff --git a/fixtures/_testCircular1Sound/pubspec.yaml b/fixtures/_testCircular1Sound/pubspec.yaml index a09869900..b1e07e8ac 100644 --- a/fixtures/_testCircular1Sound/pubspec.yaml +++ b/fixtures/_testCircular1Sound/pubspec.yaml @@ -5,7 +5,7 @@ description: >- publish_to: none environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dependencies: intl: ^0.17.0 diff --git a/fixtures/_testCircular2/pubspec.yaml b/fixtures/_testCircular2/pubspec.yaml index 8c67a6ec2..153ccb245 100644 --- a/fixtures/_testCircular2/pubspec.yaml +++ b/fixtures/_testCircular2/pubspec.yaml @@ -9,7 +9,7 @@ description: >- publish_to: none environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dependencies: _test_circular1: diff --git a/fixtures/_testCircular2Sound/pubspec.yaml b/fixtures/_testCircular2Sound/pubspec.yaml index 26200812a..51f768ab8 100644 --- a/fixtures/_testCircular2Sound/pubspec.yaml +++ b/fixtures/_testCircular2Sound/pubspec.yaml @@ -5,7 +5,7 @@ description: >- publish_to: none environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dependencies: _test_circular1_sound: diff --git a/fixtures/_testPackageSound/pubspec.yaml b/fixtures/_testPackageSound/pubspec.yaml index 882e291f1..6a41aa485 100644 --- a/fixtures/_testPackageSound/pubspec.yaml +++ b/fixtures/_testPackageSound/pubspec.yaml @@ -5,7 +5,7 @@ description: >- publish_to: none environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dependencies: _test_sound: diff --git a/fixtures/_testSound/pubspec.yaml b/fixtures/_testSound/pubspec.yaml index 677a9e4f3..bb4ae18de 100644 --- a/fixtures/_testSound/pubspec.yaml +++ b/fixtures/_testSound/pubspec.yaml @@ -5,7 +5,7 @@ description: >- publish_to: none environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dependencies: intl: ^0.17.0 diff --git a/fixtures/_webdevSmoke/pubspec.yaml b/fixtures/_webdevSmoke/pubspec.yaml index 493debe0e..fefa22f7b 100644 --- a/fixtures/_webdevSmoke/pubspec.yaml +++ b/fixtures/_webdevSmoke/pubspec.yaml @@ -14,7 +14,7 @@ publish_to: none # and build_web_compilers constraint should match those defined # in pubspec.dart. environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dev_dependencies: build_runner: '>=1.6.2 <3.0.0' diff --git a/fixtures/_webdevSoundSmoke/pubspec.yaml b/fixtures/_webdevSoundSmoke/pubspec.yaml index 3192915df..5657b84ec 100644 --- a/fixtures/_webdevSoundSmoke/pubspec.yaml +++ b/fixtures/_webdevSoundSmoke/pubspec.yaml @@ -4,7 +4,7 @@ description: A test fixture for webdev testing with sound support. publish_to: none environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dev_dependencies: build_runner: ^2.4.0 diff --git a/webdev/CHANGELOG.md b/webdev/CHANGELOG.md index 00ce7cd03..c57d81209 100644 --- a/webdev/CHANGELOG.md +++ b/webdev/CHANGELOG.md @@ -1,6 +1,7 @@ ## 3.0.7-wip - Update `build_web_compilers` constraint to `^4.0.4`. +- Update SDK constraint to `>=3.1.0-340.0.dev <4.0.0`. ## 3.0.6 diff --git a/webdev/pubspec.yaml b/webdev/pubspec.yaml index 1a4af99fc..02e8d502e 100644 --- a/webdev/pubspec.yaml +++ b/webdev/pubspec.yaml @@ -8,7 +8,7 @@ description: >- features for users and tools to build and deploy web applications with Dart. repository: https://github.com/dart-lang/webdev/tree/master/webdev environment: - sdk: ">=3.1.0-254.0.dev <4.0.0" + sdk: ">=3.1.0-340.0.dev <4.0.0" dependencies: args: ^2.3.1