Simplify Step 5

[sethladd]

Can we simplify and not use getters and setters from PirateName to the controller fields?

class BadgesController {
  // ...
  String get name => _name._firstName;
  set name(String value) {
    _name = new PirateName(firstName: value);
  }

  String get pirateName => _name.pirateName;
  // ...
}

could just be:

class BadgesController {
  PirateName pirateName;
}

The version in the code lab looks too verbose :(

Thoughts?

[a14n]

I just tried to change this but this implies some modifications in PirateName ( a firstName getter and a firstName setter ) and in the binding in the html file that do not really simplify :

     <div class="widgets">
       <div>
-        <input type="text" id="inputName" maxlength="15" ng-model="ctrl.name">
+        <input type="text" id="inputName" maxlength="15" ng-model="ctrl.pirateName.firstName">
       </div>
       <div>
         <button ng-click="ctrl.generateName()" ng-disabled="ctrl.inputIsNotEmpty">{{ctrl.label}}</button>
       </div>
     </div>
-    <badge name="{{ctrl.pirateName}}" style='float: left; margin-left: 20px;'></badge>
+    <badge name="{{ctrl.pirateName.name}}" style='float: left; margin-left: 20px;'></badge>
     <script type="application/dart" src="piratebadge.dart"></script>
     <script src="packages/browser/dart.js"></script>
   </body>

My goal was to keep the code of PirateName almost the same as the darrrt version. So I would prefer to not change this code.

[sethladd]

I think it's OK to differ from the original, if it makes sense. I'm worried that we made a controller that is also acting like a model. I think it's ok to have a binding expression like ctrl.pirateName.firstName

I'm also worried people will think we built a system like Java, with all the getters.