Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make frames manditory #10

Closed
cpiker opened this issue May 28, 2024 · 1 comment
Closed

make frames manditory #10

cpiker opened this issue May 28, 2024 · 1 comment

Comments

@cpiker
Copy link
Member

cpiker commented May 28, 2024

The vecClass attribute of element <vector> is not parsed in the serialization module, for good reason. The <frame> element defines the vector class.

Right now the stream XSD schema allows for undefined frames to be created by adhoc by vector variables without a formal frame definition. When they do it's split between the dimension level and variable level which can lead to inconsistent results.

If frames definition were mandatory, vecClass would not be needed and frame names could be moved to the variable elements.

@cpiker
Copy link
Member Author

cpiker commented Oct 30, 2024

Frames have been reworked in commit be9936e with the addition of a frame attribute for <vectors>

@cpiker cpiker closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant