Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions in SpectrogramRenderer call bundle and regex stuff during rebin operation, possibly causing slow application #93

Open
jbfaden opened this issue Dec 19, 2023 · 3 comments

Comments

@jbfaden
Copy link
Member

jbfaden commented Dec 19, 2023

I'm working on a script which is hanging for 10s of seconds and jstack shows that it is calling regex and safename operations as it rebins. This makes no sense and probably wasn't anticipated. This needs to be studied.

I'm attaching two stack dumps from the current version of Das2.

@jbfaden
Copy link
Member Author

jbfaden commented Dec 19, 2023

jstack.zip

@jbfaden
Copy link
Member Author

jbfaden commented Dec 19, 2023

It looks like if a table is both a spectrogram (having DEPEND_1) and a bundle (having BUNDLE_1), then it will use the bundle dataset for weightsDataSet. This causes things to work very slowly, because the assumption that it's a small number of datasets (X,Y,Z for example). Here I have 5000+ bundled datasets.

@jbfaden
Copy link
Member Author

jbfaden commented Dec 19, 2023

See sftp://jfaden.net/home/jbf/project/voyager/git/u/bill/20231219/analysisSaveBug93.jy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant