Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configurable templated header with jinja2 as in batchspawner #133

Open
guillaumeeb opened this issue Aug 22, 2018 · 2 comments
Open
Labels
enhancement New feature or request
Milestone

Comments

@guillaumeeb
Copy link
Member

I feel https://github.com/jupyterhub/batchspawner is using an interesting way of templating job script. See SlurmSpawner for instance.

I know we used some templated script before too, but we did not make use of jinja2 thus being force to define some useless parameters to avoid issues. This would allow us to me more easily compatible with different job scheduler versions (i.e. Torque vs PBS), and be much more generic.

Any thoughts?

See historic discussion on the current code here #7 (comment).

@jhamman
Copy link
Member

jhamman commented Aug 30, 2018

I think this is a good idea. I think our current approach made sense as a starting point but poses some challenges when maintaining many job schedulers.

@wtbarnes
Copy link
Member

I'm interested in implementing the headers as Jinja2 templates. See #338 for more details.

@guillaumeeb guillaumeeb added this to the 0.8 milestone Feb 21, 2020
@guillaumeeb guillaumeeb modified the milestones: 0.8, 0.9 Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants