-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use $HOME, hard-code it #66
Comments
The bulker config is a YacAttMap, which is a PathExAttMap -- so in theory it should be expanding those env vars... but it doesn't Writing the config uses the
@stolarczyk what's the recommended way to make this populate env vars automatically since it doesn't do it by default for
Do we need a |
isn't the default use case to keep the env vars not expanded, to maintain the configs portability?
don't want to speak for @vreuter, but to my understanding, that was exactly the idea behind this class
I don't think there is a dedicated method that does that at the moment. Working with what we have now, I'd do this: with open(path, 'w') as y:
yaml.dump(x.to_dict(expand=True), y, default_flow_style=False)
that would be useful |
This all makes sense, and you're right, I think it's the way it should be. So, what I'm looking for is |
CWL rewrites $HOME for its runs, so it doesn't work with bulker shims, which by default are mounting $HOME as an env var...
I see no real value in keeping the variable in the bulker config, so when the config is initiated, by default we should probably simply resolve the environment variable at the config build time instead of maintaining the environment variable clear through to the containerized executable scripts.
The text was updated successfully, but these errors were encountered: