Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use datafusion plan_to_sql function instead of expr_to_sql #103

Closed
hozan23 opened this issue Sep 15, 2024 · 2 comments
Closed

use datafusion plan_to_sql function instead of expr_to_sql #103

hozan23 opened this issue Sep 15, 2024 · 2 comments

Comments

@hozan23
Copy link
Collaborator

hozan23 commented Sep 15, 2024

Hello,

Following on #18, #99 and #102, we are thinking to use the plan_to_sql function within the SqlTable.scan() implementation, instead of generating the SQL query using the sql() function from SqlExec.

The proposed approach is:

  • From the scan() function -> create a new logical plan -> pass it to the plan_to_sql function -> pass the generated SQL string to SqlExec.

One concern with this approach is that we may lose the ability to implement custom logic for each engine. A possible solution would be to use the CustomDialect for engines that don't have supported dialects in DataFusion.

cc: @phillipleblanc, @backkem

@phillipleblanc
Copy link
Collaborator

This makes sense to me.

@hozan23
Copy link
Collaborator Author

hozan23 commented Oct 11, 2024

Resolved with #106

@hozan23 hozan23 closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants