You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following on #18, #99 and #102, we are thinking to use the plan_to_sql function within the SqlTable.scan() implementation, instead of generating the SQL query using the sql() function from SqlExec.
The proposed approach is:
From the scan() function -> create a new logical plan -> pass it to the plan_to_sql function -> pass the generated SQL string to SqlExec.
One concern with this approach is that we may lose the ability to implement custom logic for each engine. A possible solution would be to use the CustomDialect for engines that don't have supported dialects in DataFusion.
Hello,
Following on #18, #99 and #102, we are thinking to use the
plan_to_sql
function within theSqlTable.scan()
implementation, instead of generating the SQL query using thesql()
function fromSqlExec
.The proposed approach is:
scan()
function -> create a new logical plan -> pass it to theplan_to_sql
function -> pass the generated SQL string toSqlExec
.One concern with this approach is that we may lose the ability to implement custom logic for each engine. A possible solution would be to use the
CustomDialect
for engines that don't have supported dialects in DataFusion.cc: @phillipleblanc, @backkem
The text was updated successfully, but these errors were encountered: