From 518c1bc97cc6b2dca46c6613bf35ba0857d408ba Mon Sep 17 00:00:00 2001
From: Adam Binford <adamq43@gmail.com>
Date: Tue, 18 Jun 2024 18:04:59 +0000
Subject: [PATCH] Add constructor with config

---
 src/lib.rs | 31 ++++++++++++++++++++++++++++---
 1 file changed, 28 insertions(+), 3 deletions(-)

diff --git a/src/lib.rs b/src/lib.rs
index 73e491e..b53b5ab 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -16,6 +16,7 @@
 //! `kerberos` - Enables Kerberos authentication support via the [libgssapi](https://docs.rs/libgssapi/latest/libgssapi) crate
 //!
 use std::{
+    collections::HashMap,
     fmt::{Display, Formatter},
     future,
     path::PathBuf,
@@ -39,6 +40,10 @@ use tokio::{
     task::{self, JoinHandle},
 };
 
+// Re-export minidfs for down-stream integration tests
+#[cfg(feature = "integration-test")]
+pub use hdfs_native::minidfs;
+
 #[derive(Debug)]
 pub struct HdfsObjectStore {
     client: Arc<Client>,
@@ -78,9 +83,29 @@ impl HdfsObjectStore {
     /// # }
     /// ```
     pub fn with_url(url: &str) -> Result<Self> {
-        Ok(Self {
-            client: Arc::new(Client::new(url).to_object_store_err()?),
-        })
+        Ok(Self::new(Arc::new(Client::new(url).to_object_store_err()?)))
+    }
+
+    /// Creates a new HdfsObjectStore using the specified URL and Hadoop configs.
+    ///
+    /// Connect to a NameService
+    /// ```rust
+    /// # use hdfs_native_object_store::HdfsObjectStore;
+    /// # use std::collections::HashMap;
+    /// # fn main() -> object_store::Result<()> {
+    /// let config = HashMap::from([
+    ///     ("dfs.ha.namenodes.ns".to_string(), "nn1,nn2".to_string()),
+    ///     ("dfs.namenode.rpc-address.nn1".to_string(), "nn1.example.com:9000".to_string()),
+    ///     ("dfs.namenode.rpc-address.nn2".to_string(), "nn2.example.com:9000".to_string()),
+    /// ]);
+    /// let store = HdfsObjectStore::with_config("hdfs://ns", config)?;
+    /// # Ok(())
+    /// # }
+    /// ```
+    pub fn with_config(url: &str, config: HashMap<String, String>) -> Result<Self> {
+        Ok(Self::new(Arc::new(
+            Client::new_with_config(url, config).to_object_store_err()?,
+        )))
     }
 
     async fn internal_copy(&self, from: &Path, to: &Path, overwrite: bool) -> Result<()> {