From 7036483cf0f318eaa1b20650695eaf6267024c63 Mon Sep 17 00:00:00 2001 From: Liam Lynch Date: Mon, 16 Dec 2024 17:37:24 +0100 Subject: [PATCH 1/9] fix of 417 cols 90911 row dataset not producing a table in the hyper file [sc-219621] --- python-lib/tableau_table_writer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python-lib/tableau_table_writer.py b/python-lib/tableau_table_writer.py index 294933d..bb450ac 100644 --- a/python-lib/tableau_table_writer.py +++ b/python-lib/tableau_table_writer.py @@ -168,7 +168,7 @@ def close(self): logger.warning("Failed to perform writing on the last rows") raise err finally: - self.hyper.close() self.connection.close() + self.hyper.close() logger.info("Closed export") return True From b2b53a96b531305cacc0369e89ce4678fa6a182a Mon Sep 17 00:00:00 2001 From: Liam Lynch Date: Mon, 16 Dec 2024 17:49:12 +0100 Subject: [PATCH 2/9] 0.2.6 version updated and changelog --- CHANGELOG.md | 3 +++ plugin.json | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d6d2c59..d5ce54e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,7 @@ # Changelog +## [Version 0.2.5](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.6) - Feature release - 2024-12-06 + +- Fix: For datasets with large numbers of columns and over 90,000 rows the export/upload hyper file did not contain the table ## [Version 0.2.5](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.5) - Feature release - 2024-06-04 diff --git a/plugin.json b/plugin.json index 2ff9c05..2cb73dd 100644 --- a/plugin.json +++ b/plugin.json @@ -1,6 +1,6 @@ { "id": "tableau-hyper-export", - "version": "0.2.5", + "version": "0.2.6", "meta": { "label": "Tableau Hyper format", "description": "Export datasets to Tableau .hyper format.", From 7e449f68e8a0830d8d695c763a2be70e28ca357e Mon Sep 17 00:00:00 2001 From: Liam Lynch Date: Mon, 16 Dec 2024 17:57:45 +0100 Subject: [PATCH 3/9] corrections to changelog for 0.2.6 --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d5ce54e..6db9034 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ # Changelog -## [Version 0.2.5](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.6) - Feature release - 2024-12-06 +## [Version 0.2.6](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.6) - Feature release - 2024-12-06 -- Fix: For datasets with large numbers of columns and over 90,000 rows the export/upload hyper file did not contain the table +- Fix: Datasets with large numbers of columns and over 90,000 rows the export/upload hyper file did not contain the table exported. ## [Version 0.2.5](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.5) - Feature release - 2024-06-04 From 317703ba89523b95794f5aedd034f1e75feeb490 Mon Sep 17 00:00:00 2001 From: Liam Lynch Date: Tue, 17 Dec 2024 10:41:42 +0100 Subject: [PATCH 4/9] refine 0.2.6 changelog message --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6db9034..a0a1fa7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ # Changelog ## [Version 0.2.6](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.6) - Feature release - 2024-12-06 -- Fix: Datasets with large numbers of columns and over 90,000 rows the export/upload hyper file did not contain the table exported. +- Fix: For datasets with large numbers of columns (approximately 150 and over) and over (approximately) 90,000 rows the export/upload hyper file did not contain the table exported. This led to the failure of uploads to Tableau and the export of unusable hyper files. This was due to a wrongly ordered close statements. ## [Version 0.2.5](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.5) - Feature release - 2024-06-04 From 98bc48403f2e4fd6e89cfaaf9840ba6693cff406 Mon Sep 17 00:00:00 2001 From: Liam Lynch Date: Tue, 17 Dec 2024 11:57:49 +0100 Subject: [PATCH 5/9] corrected date in changeloG --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a0a1fa7..dbad7f6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,5 @@ # Changelog -## [Version 0.2.6](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.6) - Feature release - 2024-12-06 +## [Version 0.2.6](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.6) - Feature release - 2024-12-17 - Fix: For datasets with large numbers of columns (approximately 150 and over) and over (approximately) 90,000 rows the export/upload hyper file did not contain the table exported. This led to the failure of uploads to Tableau and the export of unusable hyper files. This was due to a wrongly ordered close statements. From f330d97ed90bc547d1eea35662164a8e52f50760 Mon Sep 17 00:00:00 2001 From: Liam Lynch Date: Tue, 17 Dec 2024 11:58:37 +0100 Subject: [PATCH 6/9] feature -> bugfix in changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dbad7f6..8df1b96 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,5 @@ # Changelog -## [Version 0.2.6](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.6) - Feature release - 2024-12-17 +## [Version 0.2.6](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.6) - Bugfix release - 2024-12-17 - Fix: For datasets with large numbers of columns (approximately 150 and over) and over (approximately) 90,000 rows the export/upload hyper file did not contain the table exported. This led to the failure of uploads to Tableau and the export of unusable hyper files. This was due to a wrongly ordered close statements. From 550818983fe27b8548e0f43e8d0f78c0836fc983 Mon Sep 17 00:00:00 2001 From: Liam Lynch Date: Tue, 17 Dec 2024 12:25:41 +0100 Subject: [PATCH 7/9] tweaks to the changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8df1b96..43fae3f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ # Changelog ## [Version 0.2.6](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.6) - Bugfix release - 2024-12-17 -- Fix: For datasets with large numbers of columns (approximately 150 and over) and over (approximately) 90,000 rows the export/upload hyper file did not contain the table exported. This led to the failure of uploads to Tableau and the export of unusable hyper files. This was due to a wrongly ordered close statements. +- Fix: For datasets with large numbers of columns rows the export/upload hyper file did not contain the table exported. This led to the failure of uploads to Tableau and the export of unusable hyper files. ## [Version 0.2.5](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.5) - Feature release - 2024-06-04 From 1570210b027d5cccce76b2f24542cb5b123d3d13 Mon Sep 17 00:00:00 2001 From: Liam Lynch Date: Tue, 17 Dec 2024 12:27:00 +0100 Subject: [PATCH 8/9] tweaks to the changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 43fae3f..52d9c2f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ # Changelog ## [Version 0.2.6](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.6) - Bugfix release - 2024-12-17 -- Fix: For datasets with large numbers of columns rows the export/upload hyper file did not contain the table exported. This led to the failure of uploads to Tableau and the export of unusable hyper files. +- Fix: For datasets with large numbers of columns the export/upload hyper file did not contain the table exported. This led to the failure of uploads to Tableau and the export of unusable hyper files. ## [Version 0.2.5](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.5) - Feature release - 2024-06-04 From fc3e5eae29d0be74ccf2a63dca18b2766dbe8339 Mon Sep 17 00:00:00 2001 From: Liam Lynch Date: Tue, 17 Dec 2024 12:27:41 +0100 Subject: [PATCH 9/9] tweaks to the changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 52d9c2f..3778fae 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ # Changelog ## [Version 0.2.6](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.6) - Bugfix release - 2024-12-17 -- Fix: For datasets with large numbers of columns the export/upload hyper file did not contain the table exported. This led to the failure of uploads to Tableau and the export of unusable hyper files. +- Fix: For datasets with large numbers of columns and rows the export/upload hyper file did not contain the table exported. This led to the failure of uploads to Tableau and the export of unusable hyper files. ## [Version 0.2.5](https://github.com/dataiku/dss-plugin-tableau-hyper/releases/tag/v0.2.5) - Feature release - 2024-06-04