Consistent library module name

[wsmelton]

I would much rather we keep the same name of the library module no matter what version of PowerShell is in use.

dbatools/dbatools.psd1

Lines 52 to 62 in cb554f5

	RequiredModules = @(
	if ($PSEdition -eq 'Core') {
	@(
	@{ ModuleName = 'dbatools.core.library'; ModuleVersion = '2022.11.8' }
	)
	} else {
	@(
	@{ ModuleName = 'dbatools.library'; ModuleVersion = '2022.11.8' }
	)
	}
	)

It will lessen the burden on our sanity with maintaining and documentation for the project.

[potatoqualitee]

Unfortunately, I do not think this is possible. Knowing exactly where a DLL will be no matter the version makes it 100x easier while loading. In addition, this will increase the size of the module and also presents problems with the way the DLL loads and we'd be back to the old way of fighting SMO.

[potatoqualitee]

OMGGGGGGGGGGGGGGGGGGGGGGGGGGGG THIS IS BEYOND RIDICULOUS AND I AM GOBSMACKED

it didnt let me publish with prerelease libraries so i did full release on the libraries and a prerelease on dbatools

I gotta go undo all that effin work. i.. i am in disbelief. WHY INTRODUCE IF PSCORE IF IT'S NOT SUPPORTED 😡 😡 😡 😡 😡 😡

[potatoqualitee]

I'll see if i can move the burden to Get-DbatoolsLibraryPath 😡

[wsmelton]

PowerShell Get v2 has this issue since 2019 PowerShell/PowerShellGetv2#595

I don’t find an issue matching on PowerShellGet repo

[wsmelton]

Do we want a command being run that will install additional bits not sourced in the original module automatically?

[potatoqualitee]

The get-dbatoolslibrarypath made it way easier, so i just undid it all and unpublished a few of the modules from the gallery. thanks for helping to clarify what was happening.

#8741

the downside is that the library is twice as big, but the upside is that this will simplify everything and keep the book relevant. i'm very surprised and disappointed that this implementation was so half baked. i dont remember if i did this in any of my other modules, but I'll need to go undo it if so 😱

[potatoqualitee]

this still shocks me

[potatoqualitee]

wrote about it here https://blog.netnerds.net/2023/03/dont-waste-your-time-with-core-versions/