Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove facet item from facets list if item is already in query #127

Open
1 task
starsinmypockets opened this issue Nov 13, 2019 · 2 comments
Open
1 task

Remove facet item from facets list if item is already in query #127

starsinmypockets opened this issue Nov 13, 2019 · 2 comments
Assignees
@starsinmypockets

Comments

@starsinmypockets
Copy link
Contributor

starsinmypockets commented Nov 13, 2019 •
edited
Loading

Steps to reproduce:

Proposed solution

NOTE I tried to implement the below solution - it is wonky as the facet items should still be shown, to get a good picture of the data facets. Rather than hiding them, they should be disabled (highlighted / unclickable) - a quick mock might be helpful.

If facet item is in query (eg: tags:Conseil), do not show in facets list:

Screen Shot 2019-11-13 at 7 47 38 AM

Acceptance Criteria

  • Do not show redundant / duplicate facet items
@starsinmypockets
Copy link
Contributor Author

@anuveyatsu can you confirm my thinking on this

@starsinmypockets starsinmypockets self-assigned this Nov 13, 2019
@starsinmypockets
Copy link
Contributor Author

See #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@starsinmypockets starsinmypockets

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@starsinmypockets