-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] In window mode, some apps don't have an icon #1931
Comments
There is no relation between "run" and "window" in source of icon. Therefor if the application does not set an icon on its windows, and the class name does not resolve to an icon, rofi has nothing to display . I am also confused, "gnome-multi-writer" has no icon under "run" only under "drun" on pop! os 22.04.. |
Yes, I meant drun, sorry. |
So is there a way I can "help" rofi resolve the icons? E.g. by manually placing them in the right spot with a resolvable name? |
This: should do it. |
Thanks, that worked. I was able to fix the other apps that way too. |
I think the frequency of this issue occurring could be reduced by searching for the executable name in .desktop files. In all of my cases the executable name is either the filename of the respective .desktop file itself (case insensitive comparison) or is part of its command field. Then the icon could be resolved from the desktop file itself. |
That won't work in rofi's design, there is no link between desktop file and window, or "executable" and window. I prefer it if applications just properly set an icon on their window. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Rofi version (rofi -v)
1.7.5-189-g11d801ea-dirty (next)
Configuration
https://gist.github.com/Luzzifus/468af44845b0729358dbd8a6bab5a3be
Theme
https://gist.github.com/Luzzifus/53e44e97dd9171f4e8a730d1adfc0321
Timing report
No response
Launch command
rofi -show window
Step to reproduce
Expected behavior
All application windows in the list should have an icon.
Actual behavior
This works for most applications, but not all. The applications in question do have an icon in drun mode, but not in window mode when they have been started already. There is no error message, just the space for the icon is blank.
Some examples for applications missing icons in window mode:
Additional information
Using wayland display server protocol
I've checked if the issue exists in the latest stable release
The text was updated successfully, but these errors were encountered: