Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: UI doesn't update as you scroll through epochs in Event History panel #353

Closed
Gregg8 opened this issue Mar 18, 2022 · 4 comments · Fixed by #365
Closed

[Bug]: UI doesn't update as you scroll through epochs in Event History panel #353

Gregg8 opened this issue Mar 18, 2022 · 4 comments · Fixed by #365
Assignees
Labels
Milestone

Comments

@Gregg8
Copy link
Contributor

Gregg8 commented Mar 18, 2022

When you press the back arrow any number of times (and forward arrow), or you click directly on an epoch, the UI remains unchanged.

I can confirm that app-db DOES correctly update, which makes it all the more confusing.

Is it updating a copy of app-db?

10x Version

1.2.3

Reagent Version

1.1.0

re-frame Version

1.2.0

What browsers are you seeing the problem on?

Chrome

@Gregg8 Gregg8 added the bug label Mar 18, 2022
@Gregg8
Copy link
Contributor Author

Gregg8 commented Mar 18, 2022

This should be added to: #302

@superstructor
Copy link
Contributor

@MawiraIke Please look at this only as bug fix on existing code. Don't attempt #302 yet. Thanks

@superstructor superstructor assigned MawiraIke and unassigned MawiraIke Jun 7, 2022
@superstructor superstructor added this to the v1.4.0 milestone Jun 7, 2022
@MawiraIke
Copy link
Contributor

@superstructor looks like this functionality already exists in settings as sync app-db with epoch navigation. However, I find it to be a pain to have to switch it every time I need to "Time travel" and so I would suggest we also add it to local-storage for persistence during page reloads e.t.c.

@superstructor
Copy link
Contributor

Thanks, agreed @MawiraIke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants