[Ctrl] + [K], ["] and [Ctrl] + [K], ['] not working on Windows.

[raaaaaymond]

Windows 10, VSCode 1.41.

Just wanted to bring to your attention that these shortcuts don't work on Windows. Last time I checked, they work on Mac (replacing [Ctrl] with [Cmd] of course). This is not a huge inconvenience right now because there is [Ctrl] + [K], [;], but I thought you might want to fix it anyway.

After checking the keyboard shortcuts settings by recording [Ctrl] + [K], ['], it shows up as "ctrl+k oem_3" in VSCode, and apparently it's bound to the command extension.selectBackTick, which seems incorrect anyway, because ['] is single-quote, not back tick. Upon recording [Ctrl] + [K], [`] and {Ctrl] + [K], ["], no corresponding commands were found.

[pfmoore]

See this comment. Should this extension be using scan codes as described, to get layout-independent behaviour?

[dbankier]

Strange. Works for me on windows. Perhaps there is a clash with another plugin?

…

On Thu, Jun 4, 2020 at 2:57 PM Paul Moore ***@***.***> wrote: See this comment <microsoft/vscode#97028 (comment)>. Should this extension be using scan codes as described, to get layout-independent behaviour? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#24 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGE3XNSO7EFMECB3WB3RGDRU6DZRANCNFSM4J55OQMA> .

[pfmoore]

Are you using a US keyboard layout? The point of the linked issue is that key bindings aren't layout independent. The problem arises with a UK keyboard layout.

A quote from later in that issue:

This is quite a mess, so we encourage the following:

1. extensions should never ship keybindings :)
2. that people use the UI for editing keybindings and don't go digging too deep because this is really ugly and we try hard to protect you from this crap :).

I can't say I like the advice that extensions shouldn't ship keybindings, but equally I can't see a way to ship bindings that is keyboard layout independent 🙁

At a minimum, I'd suggest that the documentation for this extension make it very clear that users on non-US Windows keyboards will need to remove the supplied key bindings and define their own.

[raaaaaymond]

@pfmoore Ah yes I'm using a UK keyboard.

[dbankier]

Ah! Got it. You can customise the keybindings anyway in the meantime...

…

On Wed, 2 Sep 2020, 1:30 pm raaaaaymond, ***@***.***> wrote: @pfmoore <https://github.com/pfmoore> Ah yes I'm using a UK keyboard. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGE3XJOPL5FAGFRPX7QCYTSDYNFDANCNFSM4J55OQMA> .

[raaaaaymond]

@dbankier I haven't tried recently (I'm using something else at the moment) but as far as I remember, I couldn't even rebind it, because as I mentioned in my original post, because the extension (or something in the software) seems to recognise my single quote as backtick. I'll try again when I have time.