Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Use ancestor/descendant terminology in YAML selectors instead of parent/child #10028

Closed
3 tasks done
dbeatty10 opened this issue Apr 24, 2024 · 2 comments
Closed
3 tasks done
Labels
enhancement New feature or request wontfix Not a bug or out of scope for dbt-core

Comments

@dbeatty10
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Here's essentially what our docs currently say for YAML selectors:

definition:
  method: tag
  value: nightly

  # The following optional keywords map to the `+` and `@` graph operators:
  parents: true | false
  children: true | false
  parents_depth: 1                    # + operator (left-hand side) -- degrees to include IFF parents: true
  children_depth: 1                   # + operator (right-hand side)-- degrees to include IFF children: true
  childrens_parents: true | false     # @ operator -- includes all ancestors of all descendants IFF true

This feature request is to replace:

  • parents with ancestors
  • children with descendants
  • parents_depth with ancestors_depth
  • children_depth with descendants_depth
  • childrens_parents with descendants_ancestors

Describe alternatives you've considered

Let sleeping dogs lie.

That's probably what we will do here! 🐶

Who will this benefit?

Anyone confused by what "parents" or "children" actually includes (since it has a different meaning than the standard human parent/child relationship).

For example: #7703 (comment)

We already updated some of the docs in dbt-labs/docs.getdbt.com#3755 / dbt-labs/docs.getdbt.com#5313

Are you interested in contributing this feature?

No response

Anything else?

No response

@dbeatty10 dbeatty10 added enhancement New feature or request triage labels Apr 24, 2024
@dbeatty10 dbeatty10 self-assigned this Apr 24, 2024
@dbeatty10
Copy link
Contributor Author

Here's where to find the relevant code:

Although it doesn't look like it involves a ton of code, the juice doesn't seem worth the squeeze, so I'm going to close this as "not planned".

Rather, we can address with clarifying language within the docs for YAML selectors as-needed.

If anyone disagrees, please reach out 😃

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
@dbeatty10 dbeatty10 added wontfix Not a bug or out of scope for dbt-core and removed triage labels Apr 24, 2024
@dbeatty10 dbeatty10 removed their assignment Apr 24, 2024
@dbeatty10
Copy link
Contributor Author

Made an update to the product documentation via dbt-labs/docs.getdbt.com#3755 and dbt-labs/docs.getdbt.com#5313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix Not a bug or out of scope for dbt-core
Projects
None yet
Development

No branches or pull requests

1 participant