Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Search bar should prioritise exact file name matches over fuzzy matches #217

Open
thomasaarholt opened this issue Oct 7, 2021 · 6 comments · May be fixed by #503
Open

[Feature] Search bar should prioritise exact file name matches over fuzzy matches #217

thomasaarholt opened this issue Oct 7, 2021 · 6 comments · May be fixed by #503
Labels
enhancement New feature or request help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors triage

Comments

@thomasaarholt
Copy link

Describe the bug

Searching for a model e.g. f_my_model often returns results where the model in question is surprisingly far down the list.
We often have models with similar names with different underscores, for instance a_users and b_users or f_orders_current and h_orders_old (I have had to make up some names here).

Steps To Reproduce

Open the generated dbt documentation, and search for a model name in the top bar. Type the exact model name (minus extension), and observe that the model is not always the first hit.

Expected behavior

Exact model name should be listed at the top.

Screenshots and log output

I can't provide any screenshots due to it being a private dbt project, but just to provide explicit context, this is the search field I mean:
image

The output of dbt --version:

installed version: 0.20.2
   latest version: 0.21.0

Your version of dbt is out of date! You can find instructions for upgrading here:
https://docs.getdbt.com/docs/installation

Plugins:
  - bigquery: 0.20.2
  - snowflake: 0.20.2
  - redshift: 0.20.2
  - postgres: 0.20.2```

### Additional context
Add any other context about the problem here.
@thomasaarholt thomasaarholt added the bug Something isn't working label Oct 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@rightx2
Copy link

rightx2 commented Feb 16, 2024

I think this is really serious problem. ... I don't see why this issue has been closed as completed..

@dbeatty10
Copy link
Contributor

Agreed that this should not be labeled as "completed" -- thanks for flagging this @rightx2 👍

@dbeatty10 dbeatty10 reopened this Feb 16, 2024
@dbeatty10 dbeatty10 removed the Stale label Feb 16, 2024
@dbeatty10
Copy link
Contributor

Re-categorizing this as a feature request and labeling as "help wanted".

@dbeatty10 dbeatty10 added enhancement New feature or request help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors and removed bug Something isn't working triage labels Feb 16, 2024
@dbeatty10 dbeatty10 changed the title Fuzzy search should prioritise exact file name matches [Feature] Search bar should prioritise exact file name matches over fuzzy matches Feb 16, 2024
@rightx2
Copy link

rightx2 commented Feb 17, 2024

Related comment I left on the PR: #145 (comment)

@sercancicek
Copy link

Created a PR for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors triage
Projects
None yet
4 participants