Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1755] [Spike] Move CircleCI to GitHub Actions #579

Closed
dbeatty10 opened this issue Jan 6, 2023 · 2 comments
Closed

[CT-1755] [Spike] Move CircleCI to GitHub Actions #579

dbeatty10 opened this issue Jan 6, 2023 · 2 comments
Assignees
@Fleid
Labels
duplicate This issue or pull request already exists tech_debt

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Jan 6, 2023 •
edited by Fleid
Loading

Update the CI for dbt-spark so that it is as similar as possible across all adapters maintained by dbt Labs.

See #450 for at least one known issue.

Questions to answer during the spike

  • What are the concerns that motivate us to move from CircleCI to GHA
  • Why was this repo not migrated like the others
  • Can we descope some connection methods if they are too complicated to support? Cost/Benefit of that?
  • Should we just drop the CI for this adapter if we ignore the results anyway?
@dbeatty10 dbeatty10 added enhancement New feature or request triage and removed triage labels Jan 6, 2023
@github-actions github-actions bot changed the title [Feature] Move CircleCI to GitHub Actions [CT-1755] [Feature] Move CircleCI to GitHub Actions Jan 6, 2023
@dbeatty10 dbeatty10 mentioned this issue Jan 6, 2023
Closed
6 tasks
@emmyoop emmyoop mentioned this issue Jan 27, 2023
Open
1 task
@nssalian nssalian added the jira label Mar 1, 2023
@github-actions github-actions bot changed the title [CT-1755] [Feature] Move CircleCI to GitHub Actions [CT-2252] [CT-1755] [Feature] Move CircleCI to GitHub Actions Mar 1, 2023
@nssalian nssalian removed the jira label Mar 1, 2023
@nssalian nssalian changed the title [CT-2252] [CT-1755] [Feature] Move CircleCI to GitHub Actions [CT-1755] [Feature] Move CircleCI to GitHub Actions Mar 1, 2023
@Fleid Fleid changed the title [CT-1755] [Feature] Move CircleCI to GitHub Actions [CT-1755] [Spike] Move CircleCI to GitHub Actions Mar 6, 2023
@Fleid Fleid self-assigned this Mar 6, 2023
@Fleid Fleid added tech_debt and removed enhancement New feature or request labels Mar 6, 2023
@emmyoop
Copy link
Member

emmyoop commented Mar 16, 2023

Worth looking into this: https://github.blog/changelog/2023-03-01-github-actions-importer-general-availability/

@emmyoop
Copy link
Member

emmyoop commented Apr 20, 2023

Closing in favor of #718

@emmyoop emmyoop closed this as completed Apr 20, 2023
@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
@dbeatty10 dbeatty10 added the duplicate This issue or pull request already exists label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fleid Fleid

Labels
duplicate This issue or pull request already exists tech_debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GitHub Actions for CI dbt-labs/dbt-spark
4 participants
@emmyoop @Fleid @nssalian @dbeatty10