Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Conversion to GitHub Actions #719

Closed
1 of 2 tasks
Tracked by #718
emmyoop opened this issue Apr 20, 2023 · 1 comment · Fixed by #923
Closed
1 of 2 tasks
Tracked by #718

Initial Conversion to GitHub Actions #719

emmyoop opened this issue Apr 20, 2023 · 1 comment · Fixed by #923

Comments

@emmyoop
Copy link
Member

emmyoop commented Apr 20, 2023

High Level Task

Following the pattern of the other adapters, create an integration.yml that contains the logic to replace the current CircleCI pattern.

Acceptance Criteria

  1. integration.yml exists on main in dbt-spark.
  2. It follows the patterns of the integration.yml files in other adapter repositories.
  3. It contains at least the stub of the functionality from CircleCI.
  4. Replaces fishtownanalytics/test-container:latest with setup within workflow
  5. It is not expected to be fully functional. Commenting out anything broken is fine. The workflow must exist in main to be able to fully test it. This will also allow the team to spread testing each connections among members.

Details

Leverage the GitHub migration tool to get the initial migration done. The goal of this tool is only to get you 80% of the way there.

You can do a dry run with the following command it stop it from automatically opening a PR that tells you to set up secrets:

gh actions-importer dry-run circle-ci --output-dir actions-importer/circle-ci-dry-run --circle-ci-project dbt-spark-release-test

The integration.yml in dbt-snowflake is a good reference point for what will need to be set up.

  1. triggers
  2. permissions
  3. concurrency
  4. metadata generation
  5. more?

Unknowns

  • Can we create a test matrix for the various spark flavors?
  • Do we need to test Databricks? All connection flavors?
    • answer: No, Databricks testing can be removed

Additional Notes

The repos should be set up in the settings to not allow the CI to run without explicit approval for forks. require-label-comment should no longer be necessary. Confirm this is true for spark w/ someone with admin access.

main.yml runs unit tests so they can be removed from this workflow.

@github-actions github-actions bot changed the title Initial Conversion to GitHub Action [ADAP-468] Initial Conversion to GitHub Action Apr 20, 2023
@emmyoop emmyoop changed the title [ADAP-468] Initial Conversion to GitHub Action Initial Conversion to GitHub Actions Apr 20, 2023
@emmyoop emmyoop self-assigned this Apr 25, 2023
@emmyoop emmyoop removed their assignment Aug 3, 2023
@dbeatty10
Copy link
Contributor

Resolved by #923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants