You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the existing issues, and I could not find an existing issue for this bug
Current Behavior
When running pre-commit, flake8 identifies some issues. Namely:
(dbt-spark) dbt-spark > pre-commit run --all-files
check yaml...............................................................Passed
check json...........................................(no files to check)Skipped
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for case conflicts.................................................Passed
black....................................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
dbt/adapters/spark/column.py:59:42: E231 missing whitespace after ':'
dbt/adapters/spark/column.py:60:42: E231 missing whitespace after ':'
dbt/adapters/spark/column.py:61:42: E231 missing whitespace after ':'
dbt/adapters/spark/column.py:62:42: E231 missing whitespace after ':'
dbt/adapters/spark/impl.py:239:47: E713 test for membership should be 'not in'
dbt/adapters/spark/python_submissions.py:50:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:64:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:96:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:118:31: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:129:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:197:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:211:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:232:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:248:20: E231 missing whitespace after ':'
dbt/adapters/spark/python_submissions.py:291:64: E231 missing whitespace after ':'
tests/unit/utils.py:242:72: E201 whitespace after '{'
tests/unit/utils.py:242:78: E202 whitespace before '}'
tests/unit/utils.py:242:101: E201 whitespace after '{'
tests/unit/utils.py:242:110: E202 whitespace before '}'
mypy.....................................................................Passed
Also, the flake8 config says this:
exclude = test
I believe it was intended to ignore tests. But since the tests namespace has few errors, it would be better practice to fix the errors and remove the exclude statement from the .flake8 config.
Is this a new bug in dbt-spark?
Current Behavior
When running pre-commit, flake8 identifies some issues. Namely:
Also, the flake8 config says this:
exclude = test
I believe it was intended to ignore
tests
. But since the tests namespace has few errors, it would be better practice to fix the errors and remove theexclude
statement from the.flake8
config.Expected Behavior
pre-commit
Steps To Reproduce
Run
pre-commit run --all-files
Additional Context
The text was updated successfully, but these errors were encountered: