Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable MAXIMUM_SEED_SIZE for state hash comparison #2958

Closed
1 task done
noppaz opened this issue Mar 7, 2023 · 1 comment
Closed
1 task done

Configurable MAXIMUM_SEED_SIZE for state hash comparison #2958

noppaz opened this issue Mar 7, 2023 · 1 comment
Labels
blocked_by_dev Awaiting merge of PR with associated functionality content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core Document...

Comments

@noppaz
Copy link

noppaz commented Mar 7, 2023 •
edited by matthewshaver
Loading

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/node-selection/state-comparison-caveats#seeds

What part(s) of the page would you like to see updated?

Changes to reflect the feature in dbt-labs/dbt-core#7125.

If above PR is merged, the documented behaviour remains. However, we should add documentation about the potential to use DBT_MAXIMUM_SEED_SIZE to change the maximum file size of hashed seed files. The behaviour should explain that it's set in MiB increments and that you can use 0 to remove the limit completely.

Additional information

No response

https://www.notion.so/dbtlabs/dbt-Core-v1-5-docs-a2ae11be77bf47629f85faf7a3f27991
@noppaz noppaz added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Mar 7, 2023
This was referenced Mar 7, 2023
Open
Open
@runleonarun runleonarun added dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) labels Mar 8, 2023
@jtcohen6 jtcohen6 added the blocked_by_dev Awaiting merge of PR with associated functionality label Mar 30, 2023
@jtcohen6 jtcohen6 removed the dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) label Apr 12, 2023
@jtcohen6 jtcohen6 removed this from the dbt Core v1.5 Documentation milestone Apr 12, 2023
@runleonarun runleonarun added this to the dbt Core Documentation milestone Feb 29, 2024
@mirnawong1
Copy link
Contributor

hey @noppaz , thanks for opening this up and it looks like this is still blocked by dev. I'll go ahead and close this issue out until the core PR is picked up. will keep an eye out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked_by_dev Awaiting merge of PR with associated functionality content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core Documentation
Development

No branches or pull requests
5 participants
@runleonarun @jtcohen6 @noppaz @matthewshaver @mirnawong1